Bug 1821352: vendor: Bump to pick up onsi/ginkgo panic reporting by smarterclayton · Pull Request #24916 · openshift/origin

smarterclayton · 2020-04-23T21:19:58Z

A previous performance fix meant that some panic traces from tests
were not being reported fully, making it harder to debug.

openshift-ci-robot · 2020-04-23T21:22:35Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [smarterclayton]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

smarterclayton · 2020-04-24T04:36:44Z

/retest

soltysh · 2020-04-27T10:55:59Z

@marun is working on updating origin to k8s 1.18.2 let's leave bumping ginko along that PR, pls.
@marun make sure to pick the updated version of ginko from this PR.

soltysh · 2020-04-27T10:56:05Z

/hold

smarterclayton · 2020-04-27T13:45:30Z

You don't need to pick, the branch is already updated. So it should come in. How far away is that?

marun · 2020-04-28T07:17:50Z

You don't need to pick, the branch is already updated. So it should come in. How far away is that?

Home stretch: openshift/kubernetes#122

What do I need to do?

The performance fix for ginkgo hides stack traces - pick up the fix from the upstream.

openshift-ci-robot · 2020-04-28T16:32:10Z

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-fips	`4ab4d05`	link	`/test e2e-aws-fips`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-ci-robot · 2020-05-12T07:36:50Z

@smarterclayton: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-05-19T10:53:18Z

/bugzilla refresh

openshift-ci-robot · 2020-05-19T10:53:19Z

@smarterclayton: An error was encountered adding this pull request to the external tracker bugs for bug 1821352 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/origin/pulls/24916 Error: 403 Forbidden at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x564442...', 'https://api.github.com/repos/openshift/origin/pulls/24916', 'GET') called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x564442...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5644426e49c8)') called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5644426e49c8)', 1) called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x564442ef24f8)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 877 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x564442bcb910)', 'HASH(0x564442f285c0)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x564442f285c0)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1170 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x564442fb6c78)') called at /loader/0x56443bb7c4f0/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x564442ef22a0)') called at (eval 2528) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x564442ee3948)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 295 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x564442ee3948)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x564442bcc480)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x564442feff00)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x564442feff00)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x564442bcc480)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x564442bcc480)') called at (eval 2528) line 0 eval {...} called at (eval 2528) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

Bug 1821352: vendor: Bump to pick up onsi/ginkgo panic reporting

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-05-19T10:53:22Z

@mfojtik: This pull request references Bugzilla bug 1821352, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mfojtik · 2020-05-19T10:54:05Z

/bugzilla refresh

openshift-ci-robot · 2020-05-19T10:54:08Z

@mfojtik: This pull request references Bugzilla bug 1821352, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.5.0) matches configured target release for branch (4.5.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-05-19T20:27:13Z

/close

openshift-ci-robot · 2020-05-19T20:27:27Z

@marun: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

marun · 2020-05-19T20:28:34Z

Ginkgo was bumped to include this fix by #24936

openshift-ci-robot requested review from deads2k and soltysh April 23, 2020 21:22

openshift-ci-robot added vendor-update Touching vendor dir or related files approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Apr 23, 2020

smarterclayton force-pushed the vendor branch 2 times, most recently from b4db915 to 960ba6f Compare April 23, 2020 23:25

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 27, 2020

smarterclayton added 2 commits April 28, 2020 11:18

bump(*): Pick up changes to onsi/ginkgo for stack traces on panic

cf61374

The performance fix for ginkgo hides stack traces - pick up the fix from the upstream.

vendor: Updated go.mod

4ab4d05

smarterclayton force-pushed the vendor branch from 960ba6f to 4ab4d05 Compare April 28, 2020 15:19

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2020

mfojtik changed the title ~~vendor: Bump to pick up onsi/ginkgo panic reporting~~ Bug 1821352: vendor: Bump to pick up onsi/ginkgo panic reporting May 19, 2020

openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 19, 2020

openshift-ci-robot closed this May 19, 2020

Conversation

smarterclayton commented Apr 23, 2020

Uh oh!

openshift-ci-robot commented Apr 23, 2020

Uh oh!

smarterclayton commented Apr 24, 2020

Uh oh!

soltysh commented Apr 27, 2020

Uh oh!

soltysh commented Apr 27, 2020

Uh oh!

smarterclayton commented Apr 27, 2020

Uh oh!

marun commented Apr 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 28, 2020

Uh oh!

openshift-ci-robot commented May 12, 2020

Uh oh!

mfojtik commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

mfojtik commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

marun commented May 19, 2020

Uh oh!

openshift-ci-robot commented May 19, 2020

Uh oh!

marun commented May 19, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

marun commented Apr 28, 2020 •

edited

Loading