Skip to content

Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata#766

Merged
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
marun:switch-go-bindata
Apr 24, 2020
Merged

Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata#766
openshift-merge-robot merged 4 commits intoopenshift:masterfrom
marun:switch-go-bindata

Conversation

@marun
Copy link
Copy Markdown
Contributor

@marun marun commented Apr 3, 2020 •
edited
Loading

This change is for consistency with upstream kubernetes so there is one less difference when rebasing.

It's necessary to bump build-machinery-go and api since they also depend on go-bindata.

@marun
Copy link
Copy Markdown
Contributor Author

marun commented Apr 3, 2020

/cc @sttts

@marun marun changed the title Switch from jteeuwen/go-bindata to go-bindata/go-bindata WIP: Switch from jteeuwen/go-bindata to go-bindata/go-bindata Apr 3, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 3, 2020
@marun
Copy link
Copy Markdown
Contributor Author

marun commented Apr 3, 2020

Marking WIP until openshift/build-machinery-go#13 merges.

@marun marun mentioned this pull request Apr 3, 2020
Merged
2 tasks
@marun marun changed the title WIP: Switch from jteeuwen/go-bindata to go-bindata/go-bindata Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata Apr 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

@marun: This pull request references Bugzilla bug 1826230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

@marun: This pull request references Bugzilla bug 1826230, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 24, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@openshift-merge-robot openshift-merge-robot merged commit 2aeb472 into openshift:master Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

@marun: Some pull requests linked via external trackers have merged: openshift/api#634, openshift/api#635, openshift/apiserver-library-go#28. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot mentioned this pull request Apr 24, 2020
Merged
bertinatto pushed a commit to bertinatto/library-go that referenced this pull request Jul 2, 2020
@openshift-merge-robot
Merge pull request openshift#766 from marun/switch-go-bindata
e15daf3 
Bug 1826230: Switch from jteeuwen/go-bindata to go-bindata/go-bindata
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sttts sttts Awaiting requested review from sttts

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marun @openshift-ci-robot @sttts @openshift-merge-robot