Skip to content

Bug 1826230: Switch to go-bindata/go-bindata for consistency with upstream#635

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
marun:switch-go-bindata
Apr 24, 2020
Merged

Bug 1826230: Switch to go-bindata/go-bindata for consistency with upstream#635
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
marun:switch-go-bindata

Conversation

@marun
Copy link
Copy Markdown
Contributor

@marun marun commented Apr 24, 2020

No description provided.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@marun marun changed the title WIP Switch to go-bindata/go-bindata for consistency with upstream Switch to go-bindata/go-bindata for consistency with upstream Apr 24, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 24, 2020
@sttts
Copy link
Copy Markdown
Contributor

sttts commented Apr 24, 2020

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marun, sttts

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2020
@marun marun changed the title Switch to go-bindata/go-bindata for consistency with upstream Bug 1826230: Switch to go-bindata/go-bindata for consistency with upstream Apr 24, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

@marun: This pull request references Bugzilla bug 1826230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: Switch to go-bindata/go-bindata for consistency with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@marun
Copy link
Copy Markdown
Contributor Author

marun commented Apr 24, 2020

Using the 1.18.x bump bz since this change is in support of the o/k rebase to 1.18.2

@openshift-merge-robot openshift-merge-robot merged commit 0422dc1 into openshift:master Apr 24, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 24, 2020

@marun: All pull requests linked via external trackers have merged: openshift/api#634, openshift/api#635, openshift/apiserver-library-go#28, openshift/client-go#146, openshift/library-go#778, openshift/openshift-apiserver#84. Bugzilla bug 1826230 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1826230: Switch to go-bindata/go-bindata for consistency with upstream

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Apr 24, 2020
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced May 7, 2020
Merged
Merged
Merged
Merged
Merged
@openshift-ci-robot openshift-ci-robot mentioned this pull request May 13, 2020
Merged
This was referenced May 21, 2020
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abhinavdahiya abhinavdahiya Awaiting requested review from abhinavdahiya

@adambkaplan adambkaplan Awaiting requested review from adambkaplan

Assignees

@sttts sttts

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@marun @sttts @openshift-ci-robot @openshift-merge-robot