Skip to content

Bug 1826230: 1.18.2 rebase#402

Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
ingvagabund:1.18.2-bump
Apr 29, 2020
Merged

Bug 1826230: 1.18.2 rebase#402
openshift-merge-robot merged 3 commits intoopenshift:masterfrom
ingvagabund:1.18.2-bump

Conversation

@ingvagabund
Copy link
Copy Markdown
Member

@ingvagabund ingvagabund commented Apr 27, 2020

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 27, 2020

/test e2e-cmd

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 27, 2020

/retest

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 28, 2020

Waiting for openshift/origin#24923

@soltysh soltysh changed the title 1.18.2 rebase Bug 1826230: 1.18.2 rebase Apr 28, 2020
@soltysh soltysh self-assigned this Apr 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Apr 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2020

@ingvagabund: This pull request references Bugzilla bug 1826230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: 1.18.2 rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 28, 2020
soltysh
soltysh approved these changes Apr 28, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve
/hold
for openshift/origin#24923

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Apr 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 28, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 28, 2020
@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 28, 2020

/retest

@ingvagabund
Copy link
Copy Markdown
Member Author

ingvagabund commented Apr 28, 2020

/test e2e-cmd

@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Apr 29, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Apr 29, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 5079abc into openshift:master Apr 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 29, 2020

@ingvagabund: Some pull requests linked via external trackers have merged: openshift/api#634, openshift/api#635, openshift/apiserver-library-go#28, openshift/apiserver-library-go#29, openshift/client-go#146. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1826230: 1.18.2 rebase

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund ingvagabund deleted the 1.18.2-bump branch April 29, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ingvagabund @openshift-ci-robot @soltysh @openshift-bot @openshift-merge-robot