Skip to content

Bug 1826230: bring missing fixes to oc#409

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
soltysh:bug1826230
May 7, 2020
Merged

Bug 1826230: bring missing fixes to oc#409
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
soltysh:bug1826230

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented May 7, 2020

/assign @ingvagabund
/hold
until I get the prereq merged and updated the vendored dirs.

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. labels May 7, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 7, 2020

@soltysh: This pull request references Bugzilla bug 1826230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: bring missing fixes to oc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 7, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 7, 2020
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented May 7, 2020

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 7, 2020
@ingvagabund
Copy link
Copy Markdown
Member

ingvagabund commented May 7, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 7, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 7, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit f415627 into openshift:master May 7, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 7, 2020

@soltysh: Some pull requests linked via external trackers have merged: openshift/api#634, openshift/api#635, openshift/apiserver-library-go#28, openshift/apiserver-library-go#29, openshift/client-go#146. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1826230: bring missing fixes to oc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1826230 branch May 8, 2020 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@soltysh @openshift-ci-robot @ingvagabund @openshift-merge-robot