Skip to content

Bug 1826230: bump golang for cluster-policy-controller#6772

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:bump_golang
May 13, 2020
Merged

Bug 1826230: bump golang for cluster-policy-controller#6772
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
soltysh:bump_golang

Conversation

@soltysh
Copy link
Copy Markdown
Contributor

@soltysh soltysh commented Jan 20, 2020

/assign @tnozicka

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 20, 2020
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2020
tnozicka
tnozicka reviewed Jan 21, 2020
View reviewed changes
Comment thread ...r/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
bin:
as:
- registry.svc.ci.openshift.org/ocp/builder:golang-1.12
- registry.svc.ci.openshift.org/ocp/builder:golang-1.13
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need https://github.com/openshift/cluster-policy-controller/blob/master/Dockerfile.rhel#L1 first

Copy link
Copy Markdown
Contributor Author

@soltysh soltysh Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, I'll do that in a followup to openshift/cluster-policy-controller#16

Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that PR needs to go first, the tests on this PR have no value. you also need to retrigger them when it merges. The replacement is done by string match so if you change the CI config to golang 1.13 first, you are not using it and the mismatch means you have disabled the replacement and it will use the 1.12 from dockerfile.

Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might have misinterpreted the follow up message and you already intended to do the right thing :)

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Feb 6, 2020

/test prow-config-filenames

@soltysh soltysh mentioned this pull request May 12, 2020
Merged
@soltysh soltysh changed the title Bump golang for cluster-policy-controller Bug 1826230: bump golang for cluster-policy-controller May 12, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels May 12, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 12, 2020

@soltysh: This pull request references Bugzilla bug 1826230, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

Bug 1826230: bump golang for cluster-policy-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tnozicka
Copy link
Copy Markdown
Contributor

tnozicka commented May 12, 2020

/retest

1 similar comment
@soltysh
Copy link
Copy Markdown
Contributor Author

soltysh commented May 12, 2020

/retest

@tnozicka
Copy link
Copy Markdown
Contributor

tnozicka commented May 13, 2020

/approve
/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: soltysh, tnozicka

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 20bbfac into openshift:master May 13, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2020

@soltysh: Updated the following 3 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster api.ci using the following files:
    • key openshift-cluster-policy-controller-master.yaml using file ci-operator/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-cluster-policy-controller-master.yaml using file ci-operator/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
  • ci-operator-master-configs configmap in namespace ci at cluster build01 using the following files:
    • key openshift-cluster-policy-controller-master.yaml using file ci-operator/config/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
Details

In response to this:

/assign @tnozicka

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 13, 2020

@soltysh: Some pull requests linked via external trackers have merged: openshift/api#634, openshift/api#635, openshift/apiserver-library-go#28, openshift/apiserver-library-go#29, openshift/client-go#146. The following pull requests linked via external trackers have not merged:

Details

In response to this:

Bug 1826230: bump golang for cluster-policy-controller

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bump_golang branch May 13, 2020 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@stlaz stlaz Awaiting requested review from stlaz

1 more reviewer

@tnozicka tnozicka tnozicka left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tnozicka tnozicka

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@soltysh @openshift-bot @openshift-ci-robot @tnozicka @openshift-merge-robot