Skip to content

Bug 1826230: bump golang for cluster-policy-controller #6772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
May 13, 2020
Merged

Bug 1826230: bump golang for cluster-policy-controller #6772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions ...onfig/openshift/cluster-policy-controller/openshift-cluster-policy-controller-master.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ images:
inputs:
bin:
as:
- registry.svc.ci.openshift.org/ocp/builder:golang-1.12
- registry.svc.ci.openshift.org/ocp/builder:golang-1.13
Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need https://github.com/openshift/cluster-policy-controller/blob/master/Dockerfile.rhel#L1 first

Copy link
Copy Markdown
Contributor Author

@soltysh soltysh Jan 21, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair, I'll do that in a followup to openshift/cluster-policy-controller#16

Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that PR needs to go first, the tests on this PR have no value. you also need to retrigger them when it merges. The replacement is done by string match so if you change the CI config to golang 1.13 first, you are not using it and the mismatch means you have disabled the replacement and it will use the 1.12 from dockerfile.

Copy link
Copy Markdown
Contributor

@tnozicka tnozicka Jan 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I might have misinterpreted the follow up message and you already intended to do the right thing :)

paths: null
to: cluster-policy-controller
promotion:
Expand All @@ -40,7 +40,6 @@ tests:
from: bin
- as: verify-deps
commands: |
HOME=$( mktemp -d )
make verify-deps -k --warn-undefined-variables
container:
from: src
Expand Down