SPLAT-2060: Create e2e tests for vSphere Data Disk feature#1338
SPLAT-2060: Create e2e tests for vSphere Data Disk feature#1338openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom
Conversation
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
vr4manta
force-pushed
the
test-ext-framework
branch
from
0aea6f0 to
5e45dd2
Compare
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
vr4manta
force-pushed
the
test-ext-framework
branch
from
5e45dd2 to
053cdde
Compare
openshift-merge-robot
added
the
needs-rebase
vr4manta
force-pushed
the
test-ext-framework
branch
from
053cdde to
47ba220
Compare
openshift-merge-robot
removed
the
needs-rebase
vr4manta
force-pushed
the
test-ext-framework
branch
from
47ba220 to
c1ff7ce
Compare
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @JoelSpeed |
| // If test has vsphere in title, make sure its only run on platform=vsphere | ||
| specs.Select(extensiontests.NameContains("[platform:vsphere]")). | ||
| Include(extensiontests.PlatformEquals("vsphere")) |
There was a problem hiding this comment.
Oh interesting, should we do this generically for all platforms?
There was a problem hiding this comment.
I think so. This was my way of making sure it works. I am just an e2e rookie so this is what was working for me. It did help me find a bug w/ openshift-test binary that injects --platform=skeleton whenever --dry-run is used. Would you like me to update this to strip out the platform type and dynamically inject it into equals clause?
There was a problem hiding this comment.
Yeah if it's possible/easy to make this generic for all platforms now, that would be helpful for the future I think
There was a problem hiding this comment.
@JoelSpeed I took a stab at dynamically going through all tests and adding each platform specific rule for tests with first occurrence of a new platform. Thoughts?
vr4manta
force-pushed
the
test-ext-framework
branch
2 times, most recently
from
ceb3a7f to
61fb64d
Compare
vr4manta
force-pushed
the
test-ext-framework
branch
from
61fb64d to
e117e81
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: JoelSpeed The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/retest-required |
|
/test yaml-lint |
1 similar comment
|
/test yaml-lint |
|
@hector-vido: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test yaml-lint |
|
@deepsm007: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/yaml-lint I cannot find the configuration for this check, not sure why it's being reported/blocking merges here |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/yaml-lint DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/override ci/prow/security I've checked the issue and it's unrelated, I can't clear it in the Snyk dashboard right now for some reason though |
|
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/security DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-api-operator |
8 participants
SPLAT-2060
Changes
Blocks
Notes
After this merges, we will need to update origin to register this extension so it runs in future e2e tests.
This enhancment is leveraging the following origin framework enhancement: openshift/enhancements#1676