SPLAT-2060: Registered Machine API tests extension#29579
SPLAT-2060: Registered Machine API tests extension#29579openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
@vr4manta: This pull request references SPLAT-2060 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Skipping CI for Draft Pull Request. |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
/retest |
|
/lgtm |
|
/retest |
|
/retest-required |
|
/assign @deads2k |
|
This is fantastic. I didn't realize MAO had gotten their external test binary merged. Unfortunately because the tests rely on kubernetes test framework, kube tests end up getting pulled in. We need to limit them in scope to the ones present in the repo before we can merge the origin side, otherwise you could end up replacing the kube tests with an older version from MAO. The quick path would be to filter them out after calling specs = specs.Select(extensiontests.NameContains("OCPFeatureGate:VSphereMultiDisk"))It might be possible to do this on the OTE side, I'll have a look to see if there's a sensible way to filter out vendored tests. /hold |
openshift-ci
Bot
added
the
do-not-merge/hold
Yeah, it was a bit unclear. I was hoping to initialize things correctly. I think also registering the suites may have caused such a huge number of results back. I'm happy to make any enhancement on the MAO side that you think is best. |
|
@stbenjam I may create in MAO a new field in the tests that can be used to select our repo's tests. We are working on more e2e for another feature gate and i'd hate to have to keep adding each of those to the select list. CC: @rvanderp3 |
|
@stbenjam I created PR to pull in updates to filter out vendor: openshift/machine-api-operator#1351 |
|
@stbenjam The MAPI vendor bump has merged for the filtering of the vendor found e2e tests. I believe we are now ready for approval of this change. Thanks! |
|
@vr4manta: The specified target(s) for The following commands are available to trigger optional jobs: Use DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-vsphere-ovn |
|
/assign @stbenjam |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jcpowermac, stbenjam, vr4manta The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/hold The count is wrong in some of the jobs, will look into it: |
|
/retest |
|
@stbenjam I had only reran the vsphere test. The other tests were all still old runs. Rerunning should match. I'll poke at a few real quick. |
|
/test all |
|
@stbenjam how do the runs look now? Are we comfortable to remove the hold? |
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
/test e2e-metal-ipi-ovn-ipv6 |
|
it appears that bare metal is running out of leases. should we pursue a skip on that test? |
|
@rvanderp3 the current run looks to have made it to e2e. But maybe today is just a busy day? |
|
Job Failure Risk Analysis for sha: a3484dc
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: a3484dc
New tests seen in this PR at sha: a3484dc
|
1 similar comment
|
Job Failure Risk Analysis for sha: a3484dc
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: a3484dc
New tests seen in this PR at sha: a3484dc
|
|
/skip |
|
/override ci/prow/e2e-aws-ovn-edge-zones Unrelated |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-aws-ovn-edge-zones DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@vr4manta: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Seems |
|
/retest |
|
It's a known problem that got reverted, might not be in payloads yet /override ci/prow/e2e-vsphere-ovn-upi |
|
@stbenjam: Overrode contexts on behalf of stbenjam: ci/prow/e2e-vsphere-ovn-upi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[ART PR BUILD NOTIFIER] Distgit: openshift-enterprise-tests |
7 participants
SPLAT-2060
Changes