Skip to content

SPLAT-2118: Update tests-extensions to pick up new vendor filtering#1351

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vr4manta:stbenjam-deps
Apr 7, 2025
Merged

SPLAT-2118: Update tests-extensions to pick up new vendor filtering#1351
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
vr4manta:stbenjam-deps

Conversation

@vr4manta
Copy link
Copy Markdown
Contributor

@vr4manta vr4manta commented Apr 1, 2025 •
edited
Loading

SPLAT-2118

Changes

  • Updated openshift-tests-extensions dep to get new vendor filtering logic for external tests.

Dependencies

Blocks

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 1, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@vr4manta vr4manta changed the title Update tests-extensions to pick up new vendor filtering SPLAT-2118: Update tests-extensions to pick up new vendor filtering Apr 1, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 1, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci Bot
Loading

@vr4manta: This pull request references SPLAT-2118 which is a valid jira issue.

Details

In response to this:

Changes

  • Updated openshift-tests-extensions dep to get new vendor filtering logic for external tests.

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci Bot
Loading

@vr4manta: This pull request references SPLAT-2118 which is a valid jira issue.

Details

In response to this:

SPLAT-2118

Changes

  • Updated openshift-tests-extensions dep to get new vendor filtering logic for external tests.

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci Bot
Loading

@vr4manta: This pull request references SPLAT-2118 which is a valid jira issue.

Details

In response to this:

SPLAT-2118

Changes

  • Updated openshift-tests-extensions dep to get new vendor filtering logic for external tests.

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta vr4manta marked this pull request as ready for review April 1, 2025 16:46
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 1, 2025
@openshift-ci openshift-ci Bot requested review from sub-mod and theobarberbany April 1, 2025 16:49
@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 1, 2025

/assign @JoelSpeed

@jcpowermac
Copy link
Copy Markdown
Contributor

jcpowermac commented Apr 1, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2025
@vr4manta vr4manta mentioned this pull request Apr 1, 2025
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 1, 2025 •
edited by openshift-ci Bot
Loading

@vr4manta: This pull request references SPLAT-2118 which is a valid jira issue.

Details

In response to this:

SPLAT-2118

Changes

  • Updated openshift-tests-extensions dep to get new vendor filtering logic for external tests.

Dependencies

Blocks

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Apr 2, 2025

@vr4manta Would you be able to take a look through the failures here, I see some stuff about not being able to find a k8s-tests binary which suggests that there may be something wrong with the test set up itself? Is that related?

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 3, 2025

@JoelSpeed sure, i can take a look, i got side tracked on different issue

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 3, 2025

/retest

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 3, 2025

@JoelSpeed k8s-tests-ext binary is provided by a different image. They are supposed to be cleaning somethings up too based on what we are fixing here. We can put a /hold on this while I rerun the tests if you like. but nothing so far in the logs are complaining about our new external test binary.

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 3, 2025

So far only e2e-openstack is hitting this issue:

2025/04/03 16:53:10.521938 Targeting release image "registry.build05.ci.openshift.org/ci-op-y5mwkt1p/release@sha256:6768054a2045e6a92f51d202452cd9396d282c84b0f1d01a51f01732c7aefd11" for default external binaries
2025/04/03 16:53:10.522057 Run image extract for release image "registry.build05.ci.openshift.org/ci-op-y5mwkt1p/stable@sha256:83973f32548be3e107c6b29c01b812b09fa7d7fb92e467b0266f5d835b1aed39" and src "/usr/bin/k8s-tests" at 2025-04-03 16:53:10.522055973 +0000 UTC m=+8.348829255
2025/04/03 16:53:17.185790 Run image extract for release image "registry.build05.ci.openshift.org/ci-op-y5mwkt1p/stable@sha256:83973f32548be3e107c6b29c01b812b09fa7d7fb92e467b0266f5d835b1aed39" at 6.663732828s
Suite run returned error: encountered errors while extracting binaries: failed making the extracted binary "/alabama/.cache/openshift-tests/registry_build05_ci_openshift_org_ci-op-y5mwkt1p_release_sha256_6768054a2045e6a92f51d202452cd9396d282c84b0f1d01a51f01732c7aefd11_53b95d30f28f/k8s-tests" executable: chmod /alabama/.cache/openshift-tests/registry_build05_ci_openshift_org_ci-op-y5mwkt1p_release_sha256_6768054a2045e6a92f51d202452cd9396d282c84b0f1d01a51f01732c7aefd11_53b95d30f28f/k8s-tests: no such file or directory

I'll have to ask test team if they know why this one is happening.

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 7, 2025

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2025

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/regression-clusterinfra-aws-ipi-mapi 7805661 link false /test regression-clusterinfra-aws-ipi-mapi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@vr4manta
Copy link
Copy Markdown
Contributor Author

vr4manta commented Apr 7, 2025

@JoelSpeed tests are looking good now. You ok with changes?

@JoelSpeed
Copy link
Copy Markdown
Contributor

JoelSpeed commented Apr 7, 2025

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 7, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2025
@openshift-merge-bot openshift-merge-bot Bot merged commit 3eeb288 into openshift:main Apr 7, 2025
30 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sub-mod sub-mod Awaiting requested review from sub-mod

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vr4manta @openshift-ci-robot @jcpowermac @JoelSpeed