Skip to content

Don't crash when baremetal provider is used #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 18, 2019
Merged

Don't crash when baremetal provider is used #246

openshift-merge-robot merged 1 commit into from
Mar 18, 2019

Conversation

@vrutkovs
Copy link

@vrutkovs vrutkovs commented Mar 13, 2019 •
edited
Loading

This is an incomplete version of #235, but it doesn't use baremetal operator image yet. It doesn't depend on new images (it uses libvirt actuator) so it doesn't need ART blessing for the merge

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 13, 2019
@vrutkovs vrutkovs changed the title Don't crash when baremetal provider is used WIP Don't crash when baremetal provider is used Mar 13, 2019
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
@vrutkovs vrutkovs force-pushed the initial-baremetal-support branch from 4800016 to b059b7d Compare March 13, 2019 11:51
@vrutkovs
Copy link
Author

vrutkovs commented Mar 13, 2019

/test integration

@vrutkovs vrutkovs changed the title WIP Don't crash when baremetal provider is used Don't crash when baremetal provider is used Mar 13, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 13, 2019
@vrutkovs vrutkovs force-pushed the initial-baremetal-support branch from b059b7d to f95e678 Compare March 13, 2019 14:35
@hardys hardys mentioned this pull request Mar 13, 2019
Merged
@vrutkovs
Copy link
Author

vrutkovs commented Mar 13, 2019

/test e2e-aws-operator

@vrutkovs vrutkovs force-pushed the initial-baremetal-support branch from f95e678 to f2d2867 Compare March 14, 2019 10:42
@vrutkovs
Copy link
Author

vrutkovs commented Mar 14, 2019

/retest

markmc added a commit to markmc/dev-scripts that referenced this pull request Mar 14, 2019
@markmc
Temporary hacks to fix deployment
9fe155e 
The if-name for etc discovery is no longer required because of:

openshift/machine-config-operator#547

Use a temporary release image build fo:

openshift/machine-api-operator#246
@markmc markmc mentioned this pull request Mar 14, 2019
Merged
@enxebre
Copy link
Member

enxebre commented Mar 14, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 14, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2019
@enxebre
Copy link
Member

enxebre commented Mar 14, 2019

@cynepco3hahue mind having a look at the failing test?

@enxebre
Copy link
Member

enxebre commented Mar 14, 2019

/test e2e-aws-operator

@enxebre
Copy link
Member

enxebre commented Mar 14, 2019

level=fatal msg="failed to fetch Terraform Variables: failed to fetch dependency of \"Terraform Variables\": failed to fetch dependency of \"Bootstrap Ignition Config\": failed to fetch dependency of \"Master Machines\": failed to generate asset \"Platform Credentials Check\": validate AWS credentials: checking install permissions: error simulating policy: Throttling: Rate exceeded\n\tstatus code: 400, request id: b085ecc9-4677-11e9-b4af-d9bd4fbb4a0b"

@enxebre
Copy link
Member

enxebre commented Mar 14, 2019

/test e2e-aws-operator

@ingvagabund
Copy link
Member

ingvagabund commented Mar 18, 2019

Given the baremetal is not covered by CI and the change is not breaking the current deployment, lgtm then.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 18, 2019
@openshift-merge-robot openshift-merge-robot merged commit feefc20 into openshift:master Mar 18, 2019
@vrutkovs vrutkovs mentioned this pull request Mar 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@ingvagabund ingvagabund

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vrutkovs @enxebre @openshift-ci-robot @ingvagabund @openshift-merge-robot