Add support for managed bare metal platform. #235

russellb · 2019-02-27T21:41:36Z

This patch introduces support for the managed bare metal platform that
is currently under development under the metalkube github org.

More information about this platform type can be found in
documentation under https://github.com/metalkube/metalkube-docs/.

The actuator and other supporting components are still under active
devleopment, so we just point to an upstream metalkube image for the
actuator for now. Having this in the machine-api-operator earlier
will make end-to-end testing a bit easier as the platform continues to
be developed.

Signed-off-by: Russell Bryant rbryant@redhat.com

derekwaynecarr · 2019-02-28T05:17:34Z

install/image-references

    from:
      kind: DockerImage
      name: docker.io/openshift/origin-libvirt-machine-controllers:v4.0.0
+  - name: baremetal-machine-controllers


until your image is built like all other release images in our payload, this will fail CI testing.

Thanks, Derek. I'll look into that next, then.

Images would be mirrored to docker.io once openshift/release#3066 is merged

Until ART has published baremetal-machine-controllers to quay this PR cannot be merged.

oc get istag -n ocp 4.0-art-latest:baremetal-machine-controllers Error from server (NotFound): imagestreamtags.image.openshift.io "4.0-art-latest:baremetal-machine-controllers" not found

Please work with the aos-art channel

russellb · 2019-02-28T12:09:55Z

/hold

enxebre · 2019-02-28T13:35:12Z

/approve
overall looks good to me.
@russellb FYI for e2e testing we are building a suite https://github.com/openshift/cluster-api-actuator-pkg/tree/master/pkg/e2e which validates OpenShift/machine-API conformance user stories regardless of the implementation details.

openshift-ci-robot · 2019-02-28T13:35:20Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [enxebre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ingvagabund · 2019-02-28T14:09:39Z

@russellb I am afraid you will need to rebase after #220 gets merged

russellb · 2019-03-04T21:58:07Z

I've rebased this on master after #220 merged.

Alberto, thanks for taking a look! I'll file an issue that we need to integrate with that test suite at some point.

This is still on hold, pending getting an openshift fork of our actuator created and built as part of the openshift payload. I've just asked someone to help me with that this week.

vrutkovs · 2019-03-08T20:27:03Z

/retest

vrutkovs · 2019-03-08T20:31:17Z

mage file "/tmp/release-image-0.0.1-2019-03-08-202921826698875/machine-api-operator/image-references" referenced image "baremetal-machine-controllers" that is not part of the input images

That's odd

booxter · 2019-03-09T01:36:22Z

@russellb is there a known technique on how to plug this into metalkube/dev-scripts flow? I suppose one would need to fetch the PR, build the machine operator image with the local checkout, probably push a custom image somewhere to Quay; but how one would plug it into kni-installer?

vrutkovs · 2019-03-09T10:32:44Z

Once the CI would build a release image (ci/prow/images test passes) this release can be used in dev-scripts - pass OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=registry.svc.ci.openshift.org/openshift... to kni-installer.

vrutkovs · 2019-03-11T22:03:19Z

/retest

smarterclayton · 2019-03-12T15:02:38Z

Continue to iterate, but putting

/hold

so this isn't accidentally merged until bare metal actuators is in ART.

russellb · 2019-03-13T16:41:10Z

I've rebased, and also updated the image references to refer to the openshift image, since we've now forked this actuator into openshift

vrutkovs · 2019-03-19T19:05:42Z

install/image-references

+  - name: baremetal-machine-controllers
+    from:
+      kind: DockerImage
+      name: docker.io/openshift/origin-baremetal-machine-controllers:v4.0.0


Suggested change

name: docker.io/openshift/origin-baremetal-machine-controllers:v4.0.0

name: quay.io/openshift/origin-baremetal-machine-controllers:v4.0.0

New images are no longer mirrored to docker.io

Thanks, I completed s/docker/quay/ in the patch

russellb · 2019-03-19T22:00:10Z

/test e2e-aws-operator

vrutkovs · 2019-03-20T07:45:34Z

/test e2e-aws

ingvagabund · 2019-03-20T09:00:37Z

@russellb is the PR ready for review? I still see the hold label.

russellb · 2019-03-20T21:38:38Z

@ingvagabund I think so. The actuator was added by ART and it's not breaking any CI jobs.

CC @smarterclayton since you put the /hold

This patch introduces support for the managed bare metal platform that is currently under development under the metalkube github org. More information about this platform type can be found in documentation under https://github.com/metalkube/metalkube-docs/.

vrutkovs · 2019-03-22T10:31:37Z

/retest

vrutkovs · 2019-03-22T13:05:45Z

/test ci/prow/images

vrutkovs · 2019-03-22T13:15:04Z

/retest

vrutkovs · 2019-03-22T18:33:56Z

baremetal-machine-controllers was added to 4.0-art-latest-2019-03-22-164329
/hold cancel

russellb · 2019-03-22T21:54:17Z

/retest

vrutkovs · 2019-03-26T10:01:39Z

/retest

vrutkovs · 2019-03-26T10:06:38Z

/test ci/prow/images

ingvagabund · 2019-03-26T11:46:53Z

/lgtm

openshift-ci-robot requested review from spangenberg and vikaschoudhary16 February 27, 2019 21:41

openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 27, 2019

derekwaynecarr reviewed Feb 28, 2019

View reviewed changes

openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 28, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2019

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 3, 2019

russellb force-pushed the baremetal branch from 6e32770 to 417af24 Compare March 4, 2019 21:55

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 4, 2019

russellb mentioned this pull request Mar 4, 2019

Integrate with OpenShift's machine API actuator e2e test suite metal3-io/cluster-api-provider-baremetal#15

Closed

vrutkovs mentioned this pull request Mar 8, 2019

Machine API doesn't support platform: baremetal #245

Closed

vrutkovs mentioned this pull request Mar 11, 2019

Add CI to cluster-api-provider-baremetal openshift/release#3055

Merged

3 tasks

openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019

vrutkovs mentioned this pull request Mar 13, 2019

Don't crash when baremetal provider is used #246

Merged

russellb force-pushed the baremetal branch from 417af24 to 777923b Compare March 13, 2019 13:13

openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 13, 2019

russellb force-pushed the baremetal branch from 777923b to 68899cc Compare March 13, 2019 16:40

vrutkovs reviewed Mar 19, 2019

View reviewed changes

russellb force-pushed the baremetal branch from 68899cc to 9bac5f2 Compare March 19, 2019 20:46

russellb mentioned this pull request Mar 21, 2019

Applying resources to kubevirt namespace fails with "caches not synchronized" openshift-metal3/dev-scripts#141

Closed

russellb force-pushed the baremetal branch from 9bac5f2 to 0ea2ef0 Compare March 21, 2019 21:59

openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2019

openshift-ci-robot assigned ingvagabund Mar 26, 2019

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 26, 2019

openshift-merge-robot merged commit 9d4bb9c into openshift:master Mar 26, 2019

russellb mentioned this pull request Apr 1, 2019

Certs not getting auto approved, stuck in pending state openshift-metal3/dev-scripts#260

Closed

13 tasks

	name: docker.io/openshift/origin-baremetal-machine-controllers:v4.0.0
	name: quay.io/openshift/origin-baremetal-machine-controllers:v4.0.0

Add support for managed bare metal platform. #235

Add support for managed bare metal platform. #235

Uh oh!

Conversation

russellb commented Feb 27, 2019

Uh oh!

derekwaynecarr Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

russellb Feb 28, 2019

Choose a reason for hiding this comment

Uh oh!

vrutkovs Mar 12, 2019

Choose a reason for hiding this comment

Uh oh!

smarterclayton Mar 22, 2019

Choose a reason for hiding this comment

Uh oh!

russellb commented Feb 28, 2019

Uh oh!

enxebre commented Feb 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 28, 2019

Uh oh!

ingvagabund commented Feb 28, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

russellb commented Mar 4, 2019

Uh oh!

vrutkovs commented Mar 8, 2019

Uh oh!

vrutkovs commented Mar 8, 2019

Uh oh!

booxter commented Mar 9, 2019

Uh oh!

vrutkovs commented Mar 9, 2019

Uh oh!

vrutkovs commented Mar 11, 2019

Uh oh!

smarterclayton commented Mar 12, 2019

Uh oh!

russellb commented Mar 13, 2019

Uh oh!

vrutkovs Mar 19, 2019

Choose a reason for hiding this comment

Uh oh!

russellb Mar 19, 2019

Choose a reason for hiding this comment

Uh oh!

russellb commented Mar 19, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vrutkovs commented Mar 20, 2019

Uh oh!

ingvagabund commented Mar 20, 2019

Uh oh!

russellb commented Mar 20, 2019

Uh oh!

vrutkovs commented Mar 22, 2019

Uh oh!

vrutkovs commented Mar 22, 2019

Uh oh!

vrutkovs commented Mar 22, 2019

Uh oh!

vrutkovs commented Mar 22, 2019

Uh oh!

russellb commented Mar 22, 2019

Uh oh!

vrutkovs commented Mar 26, 2019

Uh oh!

vrutkovs commented Mar 26, 2019

Uh oh!

ingvagabund commented Mar 26, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

enxebre commented Feb 28, 2019 •

edited

Loading

ingvagabund commented Feb 28, 2019 •

edited

Loading

russellb commented Mar 19, 2019 •

edited

Loading