Add CI to cluster-api-provider-baremetal

[vrutkovs]

This PR would ensure images for Openshift CI are built and tested. Verified e2e tests work on ci-stg namespace

TODO:

• Wait for Add OWNERS cluster-api-provider-baremetal#2 to land so that OWNERS file would be generated here
• Merge Change cluster-api-provider-baremetal repo path cluster-api-provider-baremetal#3 to fix unittests
• Avoid building kustomize in unittests cluster-api-provider-baremetal#4 to avoid generating kustomize manifests

This doesn't run unittest or e2e tests yet - these will be added later

Fixes metal3-io/cluster-api-provider-baremetal#15
Required to unblock openshift/machine-api-operator#235

[vrutkovs]

/test pj-rehearse

[openshift-ci-robot]

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/rehearse/openshift/cluster-api-provider-baremetal/master/unit	4da76e8cb1325958ee3ad111c40398258eed4be8	link	/test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[vrutkovs]

/cc @stevekuznetsov

[stevekuznetsov]

What's up?

go generate ./pkg/... ./cmd/...
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go all
CRD manifests generated under '/go/src/github.com/metalkube/cluster-api-provider-baremetal/config/crds' 
RBAC manifests generated under '/go/src/github.com/metalkube/cluster-api-provider-baremetal/config/rbac' 
kustomize build config/default/ > provider-components.yaml
/bin/sh: kustomize: command not found
make: *** [manifests] Error 127

Your test would fail

[vrutkovs]

Right, unittests expect a) kustomize b) proper control plane to pass, so these are not yet included - we'll add proper e2e later on

[stevekuznetsov]

So you want to add a blocking presubmit that doesn't work to the repo? Won't that make it impossible to merge into it? Ican appove but that seems like the opposite of what you usually want lol

[vrutkovs]

It does work, it just won't run unittests and e2e yet. The main goal is to have this image included in the release payload to unblock failures in openshift/machine-api-operator#235

[stevekuznetsov]

But isn't the unit test going to be blocking? lol I don't really mind but I imagine devs won't be too happy

/lgtm
/approve

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@vrutkovs: Updated the following 3 configmaps:

• ci-operator-master-configs configmap in namespace ci using the following files:
  • key openshift-cluster-api-provider-baremetal-master.yaml using file ci-operator/config/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master.yaml
• ci-operator-master-configs configmap in namespace ci-stg using the following files:
  • key openshift-cluster-api-provider-baremetal-master.yaml using file ci-operator/config/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master.yaml
• job-config-master configmap in namespace ci using the following files:
  • key openshift-cluster-api-provider-baremetal-master-postsubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master-postsubmits.yaml
  • key openshift-cluster-api-provider-baremetal-master-presubmits.yaml using file ci-operator/jobs/openshift/cluster-api-provider-baremetal/openshift-cluster-api-provider-baremetal-master-presubmits.yaml

Details

In response to this:

This PR would ensure images for Openshift CI are built and tested. Verified e2e tests work on ci-stg namespace

TODO:

• Wait for Add OWNERS cluster-api-provider-baremetal#2 to land so that OWNERS file would be generated here
• Merge Change cluster-api-provider-baremetal repo path cluster-api-provider-baremetal#3 to fix unittests
• Avoid building kustomize in unittests cluster-api-provider-baremetal#4 to avoid generating kustomize manifests

This doesn't run unittest or e2e tests yet - these will be added later

Fixes metal3-io/cluster-api-provider-baremetal#15
Required to unblock openshift/machine-api-operator#235

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.