Skip to content

Allow to enable/disable machine healtch-check controller #291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 4 commits into from
Apr 19, 2019
Merged

Allow to enable/disable machine healtch-check controller #291

openshift-merge-robot merged 4 commits into from
Apr 19, 2019

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Apr 17, 2019 •
edited
Loading

So we can use feature gate mechanism to enable/disable the controller.

One needs to deploy:

apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  name: machine-api
spec:
  featureSet: "TechPreviewNoUpgrade"

to enable the HC deployment. Tested through unit tests where a fake clientset with the feature gate is provided.

Feature gate building pieces took from #279

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 17, 2019
@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 17, 2019

/test integration

ingvagabund and others added 4 commits April 18, 2019 17:56
@ingvagabund
Allow to enable/disable machine healtch-check controller
c323588
@ingvagabund
Add supports for the FeatureGate
1813778 
Machine-api-operator controller will watch FeatureGate resources and
update the deployment accordingly.

Currently the only one feature that can be enabled via the
FeatureGate object is MachineHealthCheck. To enable it you will
need to create FeatureGate object with the content:
```yaml
apiVersion: config.openshift.io/v1
kind: FeatureGate
metadata:
  name: machine-api
spec:
  featureSet: "TechPreviewNoUpgrade"
```
@ingvagabund
Unit test feature gate for HC
dc8b65f
@ingvagabund
Update dependencies
74246b7 
By running 'dep ensure'
@ingvagabund ingvagabund force-pushed the feature-gating-for-machine-healthcheck-controller branch from ebb547e to 74246b7 Compare April 18, 2019 16:03
@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 18, 2019
@ingvagabund ingvagabund changed the title WIP: Allow to enable/disable machine healtch-check controller Allow to enable/disable machine healtch-check controller Apr 18, 2019
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2019
@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 18, 2019

@cynepco3hahue PTAL, I have integrated your feature gate PR, modified it a bit, added unit tests.

@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 18, 2019

/retest

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 18, 2019 •
edited
Loading

@ingvagabund: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 74246b7 link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

ingvagabund commented Apr 18, 2019

/test e2e-aws

@michaelgugino
Copy link
Contributor

michaelgugino commented Apr 19, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2019
@michaelgugino
Copy link
Contributor

michaelgugino commented Apr 19, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 19, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: michaelgugino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2019
@openshift-merge-robot openshift-merge-robot merged commit 439a9d9 into openshift:master Apr 19, 2019
@ingvagabund ingvagabund deleted the feature-gating-for-machine-healthcheck-controller branch April 19, 2019 00:15
@enxebre enxebre mentioned this pull request Apr 22, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@spangenberg spangenberg Awaiting requested review from spangenberg

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@michaelgugino michaelgugino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ingvagabund @openshift-ci-robot @michaelgugino @openshift-merge-robot