Skip to content

fix feature gate #293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 4 commits into from
Apr 23, 2019
Merged

fix feature gate #293

openshift-merge-robot merged 4 commits into from
Apr 23, 2019

Conversation

@enxebre
Copy link
Member

@enxebre enxebre commented Apr 22, 2019

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 22, 2019
@michaelgugino
Copy link
Contributor

michaelgugino commented Apr 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@enxebre
Copy link
Member Author

enxebre commented Apr 22, 2019

/test e2e-aws

ingvagabund
ingvagabund reviewed Apr 22, 2019
View reviewed changes
pkg/operator/operator_test.go
return false
}

func TestOperatorSyncClusterAPIControllerHealthCheckControllerNotDeployed(t *testing.T) {
Copy link
Member

@ingvagabund ingvagabund Apr 22, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I put the tests under two separete functions so it's obvious which case is tested. Though, if you feel it's better this way, I am fine with that.

Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table driven tests is the recommended approach i guess, https://github.com/golang/go/wiki/TableDrivenTests

Copy link
Contributor

@frobware frobware Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find that it depends. Quite often table driven tests end up adding complexity and sometimes I find it easier to do:

func TestFooDoesX

func TestFooErrorsWithBar

func TestFooSucceedsWithKnownInputs

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Apr 22, 2019
@michaelgugino
Copy link
Contributor

michaelgugino commented Apr 22, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Apr 22, 2019
@enxebre enxebre changed the title Disable machine health check by default fix feature gate Apr 22, 2019
@enxebre
Copy link
Member Author

enxebre commented Apr 22, 2019

/test integration

1 similar comment
@ingvagabund
Copy link
Member

ingvagabund commented Apr 23, 2019

/test integration

ingvagabund
ingvagabund reviewed Apr 23, 2019
View reviewed changes
install/0000_30_machine-api-operator_08_rbac.yaml
verbs:
- get

- apiGroups:
Copy link
Member

@ingvagabund ingvagabund Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, extend https://github.com/openshift/machine-api-operator/blob/master/config/machine-api-operator-patch.yaml as well.

Copy link
Member

@ingvagabund ingvagabund Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in #295

@ingvagabund
Copy link
Member

ingvagabund commented Apr 23, 2019

Blocked by #295

@ingvagabund ingvagabund mentioned this pull request Apr 23, 2019
Closed
@ingvagabund
Copy link
Member

ingvagabund commented Apr 23, 2019

/approve

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 23, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ingvagabund

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 23, 2019
vikaschoudhary16
vikaschoudhary16 reviewed Apr 23, 2019
View reviewed changes
config/0000_05_config-operator_01_featuregate.crd.yaml
apiVersion:
description: 'APIVersion defines the versioned schema of this representation
of an object. Servers should convert recognized schemas to the latest
internal value, and may reject unrecognized values. More info: https://git.k8s.io/community/contributors/devel/api-conventions.md#resources'
Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/value, and/value and

Copy link
Member

@ingvagabund ingvagabund Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copy-pasted the CRD, cant' fix that.

pkg/operator/operator_test.go
return false
}

func TestOperatorSyncClusterAPIControllerHealthCheckControllerNotDeployed(t *testing.T) {
Copy link
Contributor

@vikaschoudhary16 vikaschoudhary16 Apr 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table driven tests is the recommended approach i guess, https://github.com/golang/go/wiki/TableDrivenTests

frobware
frobware requested changes Apr 23, 2019
View reviewed changes
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 23, 2019

@enxebre: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/actuator-pkg-staleness 1f46dde link /test actuator-pkg-staleness

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@frobware
Copy link
Contributor

frobware commented Apr 23, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 23, 2019
@openshift-merge-robot openshift-merge-robot merged commit dd8d2cf into openshift:master Apr 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ingvagabund ingvagabund ingvagabund left review comments

@frobware frobware frobware approved these changes

@bison bison Awaiting requested review from bison

@spangenberg spangenberg Awaiting requested review from spangenberg

+1 more reviewer

@vikaschoudhary16 vikaschoudhary16 vikaschoudhary16 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@frobware frobware

@michaelgugino michaelgugino

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@enxebre @michaelgugino @ingvagabund @openshift-ci-robot @frobware @vikaschoudhary16 @openshift-merge-robot