OCPBUGS-83873: Changed timeout for node ready logic in OTE

[vr4manta]

OCPBUGS-83873

Changes

• Changed timeout for node ready logic to 5 minutes (from 2)
• Added flag to cleanup complete so we do not attempt twice

Summary by CodeRabbit

• Bug Fixes

  • Fixed potential duplicate cleanup execution in dedicated host tests by implementing proper cleanup state tracking.
  • Increased timeout for node registration detection to improve test reliability and reduce intermittent failures.

• Tests

  • Enhanced test robustness with improved cleanup handling logic.

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-83873, which is invalid:

• expected the bug to target the "5.0.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

OCPBUGS-83873

Changes

• Changed timeout for node ready logic to 5 minutes (from 2)
• Added flag to cleanup complete so we do not attempt twice

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

The dedicated host test adds cleanup state tracking via a boolean flag to prevent duplicate cleanup execution, and increases the polling timeout for node registration from 2 minutes to 5 minutes in the cleanup helper function.

Changes

Cohort / File(s)	Summary
Test Cleanup Logic openshift-tests/test/e2e/dedicated_hosts.go	Introduces cleanupComplete boolean flag to track cleanup execution state, sets up DeferCleanup to conditionally execute cleanup, and increases node registration polling timeout from 2*time.Minute to 5*time.Minute.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 10 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	⚠️ Warning	Test file has multiple quality issues: assertions lack meaningful failure messages and cleanup pattern uses awkward boolean flag instead of Ginkgo v2 idioms.	Add meaningful failure messages to Expect().NotTo(HaveOccurred()) assertions and refactor cleanup logic to avoid boolean flags.
Microshift Test Compatibility	❓ Inconclusive	Git history check for openshift-tests/test/e2e/dedicated_hosts.go cannot be executed without repository access.	Execute the command in a valid git repository containing the file to retrieve commit history.

✅ Passed checks (10 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	All Ginkgo test definitions use stable, descriptive names without dynamic information, ensuring deterministic and reproducible test execution.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	No new Ginkgo e2e tests are being added; only existing test modifications for cleanup tracking and timeout adjustments.
Topology-Aware Scheduling Compatibility	✅ Passed	Changes are limited to test file cleanup logic and timeout adjustments with no impact on production scheduling or topology constraints.
Ote Binary Stdout Contract	✅ Passed	The pull request modifies a Ginkgo v2 test file with proper OTE Binary Stdout Contract compliance. All stdout writes use GinkgoWriter.Printf() within test blocks, and no process-level stdout violations are introduced.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The new Ginkgo e2e test file for AWS Dedicated Hosts contains no IPv4 assumptions or external connectivity requirements.
Title check	✅ Passed	The PR title references OCPBUGS-83873 and mentions 'Changed timeout for node ready logic', which directly aligns with the main change described in the objectives and raw summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-83873, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

OCPBUGS-83873

Changes

• Changed timeout for node ready logic to 5 minutes (from 2)
• Added flag to cleanup complete so we do not attempt twice

Summary by CodeRabbit

• Bug Fixes

• Fixed potential duplicate cleanup execution in dedicated host tests by implementing proper cleanup state tracking.

• Increased timeout for node registration detection to improve test reliability and reduce intermittent failures.

• Tests

• Enhanced test robustness with improved cleanup handling logic.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/jira refresh

[openshift-ci-robot]

@vr4manta: This pull request references Jira Issue OCPBUGS-83873, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[vr4manta]

/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated-serial-techpreview-1of2
/payload-job periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated-serial-techpreview-2of2

[openshift-ci]

@vr4manta: trigger 2 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated-serial-techpreview-1of2
• periodic-ci-openshift-release-main-nightly-4.22-e2e-aws-ovn-dedicated-serial-techpreview-2of2

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d334d7f0-3e44-11f1-82aa-98624e9aa4ff-0

[vr4manta]

Payload jobs ran and all DH tests passed.

[RadekManak]

/lgtm
/approve

[RadekManak]

/verified by payload jobs

[openshift-ci-robot]

@RadekManak: This PR has been marked as verified by payload jobs.

Details

In response to this:

/verified by payload jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [RadekManak]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/lgtm

[damdo]

/test e2e-aws

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD cba0ea7 and 2 for PR HEAD 43bfd86 in total

[damdo]

/test e2e-aws

[damdo]

/test e2e-aws

[vr4manta]

/retest

[openshift-ci]

@vr4manta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	43bfd86	link	true	/test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.