Skip to content

OCPBUGS-83873: Changed timeout for node ready logic in OTE #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vr4manta wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −3
Open

OCPBUGS-83873: Changed timeout for node ready logic in OTE #185

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions openshift-tests/test/e2e/dedicated_hosts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,9 +488,12 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:AWSDedicatedHosts][plat
Expect(err).NotTo(HaveOccurred())
Expect(createdMachine).NotTo(BeNil())

// Register cleanup immediately after successful creation
cleanupComplete := false
// Register cleanup immediately after successful creation in case test fails before the manual cleanup
DeferCleanup(func() {
cleanupMachineAndNode(ctx, kubeConfig, kubeClient, machineName)
if !cleanupComplete {
cleanupMachineAndNode(ctx, kubeConfig, kubeClient, machineName)
}
})

var dynamicHostID string
Expand Down Expand Up @@ -534,6 +537,7 @@ var _ = Describe("[sig-cluster-lifecycle][OCPFeatureGate:AWSDedicatedHosts][plat

// Manually trigger cleanup before verifying host release
cleanupMachineAndNode(ctx, kubeConfig, kubeClient, machineName)
cleanupComplete = true

By("Verifying dynamically allocated host is released after cleanup")
GinkgoWriter.Printf("Verifying dynamically allocated host %s is released after cleanup\n", dynamicHostID)
Expand Down Expand Up @@ -937,7 +941,7 @@ func cleanupMachineAndNode(ctx context.Context, kubeConfig *rest.Config, kubeCli
return true
}
return false
}, 2*time.Minute, defaultPollingInterval).Should(BeTrue())
}, 5*time.Minute, defaultPollingInterval).Should(BeTrue())
}

// Delete the machine
Expand Down