Add Profile and Trunks to Ports and Networks#35
Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom Apr 13, 2022
Merged
Add Profile and Trunks to Ports and Networks#35openshift-merge-robot merged 2 commits intoopenshift:masterfrom
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Conversation
Seems like these options got added in late CAPO and we haven't copied them to MAPO. So this commit adds them again.
When building the `machineSpec.Ports` parameter, we need to take in account the networks first, and then the additional ports. The reason is that when using the legacy cloud provider, the main interface (from a Nova standpoint) will be used to bind the kubelet process and this changes when using the new cloud provider with CCM.
Contributor
|
@dulek: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Member
|
/lgtm Thanks for this work guys! |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems like these options got added in late CAPO and we haven't copied
them to MAPO. So this commit adds them again.