machine/convert: reverse machineSpec.Ports order#36
machine/convert: reverse machineSpec.Ports order#36EmilienM wants to merge 1 commit intoopenshift:masterfrom
Conversation
When building the `machineSpec.Ports` parameter, we need to take in account the networks first, and then the additional ports. The reason is that when using the legacy cloud provider, the main interface (from a Nova standpoint) will be used to bind the kubelet process and this changes when using the new cloud provider with CCM.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@EmilienM: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
I've rebased this and folded it into #35 |
openshift-ci
Bot
added
the
needs-rebase
|
@EmilienM: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@EmilienM: PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/close |
1 similar comment
|
/close |
|
@mdbooth: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mdbooth: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
2 participants
When building the
machineSpec.Portsparameter, we need to take inaccount the networks first, and then the additional ports.
The reason is that when using the legacy cloud provider, the main
interface (from a Nova standpoint) will be used to bind the kubelet
process and this changes when using the new cloud provider with CCM.