Skip to content

machine/convert: reverse machineSpec.Ports order #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EmilienM wants to merge 1 commit into from
Closed

machine/convert: reverse machineSpec.Ports order #36

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion pkg/machine/convert.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,9 @@ func providerSpecToMachineSpec(ps *openstackconfigv1.OpenstackProviderSpec, apiV
portList = append(portList, ports...)
}

machineSpec.Ports = append(machineSpec.Ports, portList...)
// The order of the networks is important, first network is the one that will be used for kubelet when
// the legacy cloud provider is used. Once we switch to using CCM by default, the order won't matter.
machineSpec.Ports = append(portList, machineSpec.Ports...)

return machineSpec, nil
}