Skip to content

Bug 1769581: 4.2: Specfile: Make %global commit ... overridable#1249

Merged
openshift-merge-robot merged 1 commit intoopenshift:release-4.2from
LorbusChris:release-4.2
Nov 21, 2019
Merged

Bug 1769581: 4.2: Specfile: Make %global commit ... overridable#1249
openshift-merge-robot merged 1 commit intoopenshift:release-4.2from
LorbusChris:release-4.2

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

Backport of #1225
Blocks: openshift/release#5572

- What I did
Make %global commit foo overridable with rpmbuild --define "commit bar"

- How to verify it
CI does not break

- Description for the changelog
Specfile: Make %global commit ... overridable

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

4.2: Specfile: Make %global commit ... overridable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 6, 2019
@LorbusChris LorbusChris changed the title 4.2: Specfile: Make %global commit ... overridable Bug 1769581: 4.2: Specfile: Make %global commit ... overridable Nov 6, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 6, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: This pull request references Bugzilla bug 1769581, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1769581: 4.2: Specfile: Make %global commit ... overridable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: This pull request references Bugzilla bug 1769581, which is invalid:

  • expected the bug to target the "4.2.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice: This pull request references Bugzilla bug 1769581, which is invalid:

  • expected dependent Bugzilla bug 1769578 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

Ok this is set now. :)

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh
/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: This pull request references Bugzilla bug 1769581, which is invalid:

  • expected dependent Bugzilla bug 1769578 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh
/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@runcom
Copy link
Copy Markdown
Member

runcom commented Nov 15, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 15, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, LorbusChris, runcom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LorbusChris,ashcrow,runcom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 21, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: This pull request references Bugzilla bug 1769581, which is valid.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/cherry-pick approve

@openshift-cherrypick-robot
Copy link
Copy Markdown

@LorbusChris: once the present PR merges, I will cherry-pick it on top of approve in a new PR and assign it to you.

Details

In response to this:

/cherry-pick approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris LorbusChris added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 21, 2019
@openshift-merge-robot openshift-merge-robot merged commit 46f291c into openshift:release-4.2 Nov 21, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: All pull requests linked via external trackers have merged. Bugzilla bug 1769581 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1769581: 4.2: Specfile: Make %global commit ... overridable

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@LorbusChris: cannot checkout approve: error checking out approve: exit status 1. output: error: pathspec 'approve' did not match any file(s) known to git.

Details

In response to this:

/cherry-pick approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris LorbusChris deleted the release-4.2 branch February 24, 2020 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants