Skip to content

[fcos] Specfile: Make %global commit ... overridable#1225

Merged
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
LorbusChris:spec-fcos
Oct 30, 2019
Merged

[fcos] Specfile: Make %global commit ... overridable#1225
openshift-merge-robot merged 1 commit intoopenshift:fcosfrom
LorbusChris:spec-fcos

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

Blocks: openshift/release#5659

- What I did
Make %global commit foo overridable with rpmbuild --define "commit bar"

- How to verify it
This should unblock the build-rpms-from-tar job over in openshift/release#5659

- Description for the changelog
Specfile: Make %global commit ... overridable

@LorbusChris LorbusChris requested a review from cgwalters October 29, 2019 22:53
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 29, 2019
@LorbusChris LorbusChris changed the title Specfile: Make %global commit ... overridable [fcos] Specfile: Make %global commit ... overridable Oct 29, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

/test e2e-aws

@ericavonb
Copy link
Copy Markdown

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ericavonb, LorbusChris

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [LorbusChris,ericavonb]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@LorbusChris
Copy link
Copy Markdown
Contributor Author

/retest

2 similar comments
@LorbusChris
Copy link
Copy Markdown
Contributor Author

/retest

@smarterclayton
Copy link
Copy Markdown
Contributor

/retest

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/e2e-aws 2a20255 link /test e2e-aws

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Copy Markdown
Contributor

Oh, this won't pass.

/override ci/prow/e2e-aws

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@smarterclayton: Overrode contexts on behalf of smarterclayton: ci/prow/e2e-aws

Details

In response to this:

Oh, this won't pass.

/override ci/prow/e2e-aws

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants