Skip to content

Add MCD RPM builds on fcos branch of MCO#5659

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:okdci
Oct 30, 2019
Merged

Add MCD RPM builds on fcos branch of MCO#5659
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:okdci

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris commented Oct 29, 2019

Analogous to #5572

but without the changes in ci-operator/config/openshift/origin/openshift-origin-master.yaml (see https://github.com/openshift/release/pull/5572/files#diff-cd17a5d207369e19a76d7a3dbe835d38)

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 29, 2019

/assign @smarterclayton

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 29, 2019

See my comment on the previous commit

@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 29, 2019

please have another look!

@LorbusChris LorbusChris force-pushed the okdci branch 2 times, most recently from 13fefe2 to 2d24ef7 Compare October 29, 2019 19:28
@LorbusChris LorbusChris mentioned this pull request Oct 29, 2019
Merged
@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 29, 2019

I'm wondering whether we also need a test to trigger the rpms target here, like in https://github.com/openshift/release/blob/master/ci-operator/config/openshift/oc/openshift-oc-master.yaml#L97-L100

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 29, 2019

It can’t hurt, and makes the failure more obvious on a PR

@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 29, 2019

added the test

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 29, 2019
@LorbusChris LorbusChris force-pushed the okdci branch 6 times, most recently from fcec52b to 10ace15 Compare October 29, 2019 22:40
@LorbusChris LorbusChris mentioned this pull request Oct 29, 2019
Merged
@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 29, 2019

Blocked by: openshift/machine-config-operator#1225

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 30, 2019

/test pj-rehearse

@LorbusChris LorbusChris force-pushed the okdci branch 5 times, most recently from e3fdb8c to 7191793 Compare October 30, 2019 06:15
@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 30, 2019

/lgtm

Can you port this to all the other branches 4.2+?

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, LorbusChris, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 388e8ea into openshift:master Oct 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 30, 2019

@LorbusChris: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
  • ci-operator-misc-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
  • job-config-misc configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-fcos-postsubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-fcos-postsubmits.yaml
    • key openshift-machine-config-operator-fcos-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-fcos-presubmits.yaml
Details

In response to this:

Analogous to #5572

but without the changes in ci-operator/config/openshift/origin/openshift-origin-master.yaml (see https://github.com/openshift/release/pull/5572/files#diff-cd17a5d207369e19a76d7a3dbe835d38)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris added a commit to LorbusChris/release that referenced this pull request Nov 25, 2019
@LorbusChris
MCD RPM and os container builds for 4.2+ branches
7a3ebbf 
Porting openshift#5659 openshift#5681 openshift#5695 to all branches from 4.2 to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

2 more reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@ashcrow ashcrow ashcrow approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashcrow ashcrow

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@LorbusChris @smarterclayton @openshift-ci-robot @ashcrow @openshift-merge-robot