Skip to content

Remove sources from mco rpms container#5681

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:rmsrc
Oct 30, 2019
Merged

Remove sources from mco rpms container#5681
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:rmsrc

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

Also removes /srv/repo symlink and moves content there instead

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 30, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 30, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

this only affects fcos, correct?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be even easier. rm -rf ${RPMBUILD_DIR}. We only want things in the root /srv/repo anyway.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, should I copy over the srpm before that, or just leave that out for now?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

leave it out for now

@LorbusChris
Copy link
Copy Markdown
Contributor Author

@kikisdeliveryservice Yes, for now. Once we have this set up correctly, I'll port it to all ocp branches 4.2+

Also removes `/srv/repo` symlink and moves RPMS content there instead
@smarterclayton
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5586d74 into openshift:master Oct 30, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: Updated the following 2 configmaps:

  • ci-operator-misc-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
  • ci-operator-misc-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
Details

In response to this:

Also removes /srv/repo symlink and moves content there instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

LorbusChris added a commit to LorbusChris/release that referenced this pull request Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants