Skip to content

mco-fcos: Build os container with MCD RPM for each PR#5695

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:mco-oscontainer
Oct 31, 2019
Merged

mco-fcos: Build os container with MCD RPM for each PR#5695
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
LorbusChris:mco-oscontainer

Conversation

@LorbusChris
Copy link
Copy Markdown
Contributor

@LorbusChris LorbusChris commented Oct 31, 2019 •
edited
Loading

Build os container with MCD RPM for each PR

@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 31, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 31, 2019
@LorbusChris
Copy link
Copy Markdown
Contributor Author

LorbusChris commented Oct 31, 2019

/assign @smarterclayton

DanyC97
DanyC97 reviewed Oct 31, 2019
View reviewed changes
Comment thread ...perator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml Outdated
Copy link
Copy Markdown

@DanyC97 DanyC97 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

am i missing s'thing @LorbusChris w.r.t the version ? i thought will be 31 ?

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

29 has proven to work so far, we'll update this soon!

Copy link
Copy Markdown

@DanyC97 DanyC97 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair point, thx for the info

Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can actually switch to coreos-assembler now, but haven't yet got to it.

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm planning to port these changes to 4.2+ OCP branches. Should I wait for the switch to cosa with that?

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 31, 2019

Hrm, why did fcos/e2e-aws not fire?

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 31, 2019

Oh, go ahead and touch that definition in your commit (change a label or something) (then we can test that it works in rehearse)

@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 31, 2019
sgreene570
sgreene570 reviewed Oct 31, 2019
View reviewed changes
Comment thread ...obs/openshift/machine-config-operator/openshift-machine-config-operator-fcos-presubmits.yaml
- name: TEST_COMMAND
value: TEST_SUITE=openshift/conformance/parallel run-tests
value: |
TEST_SUITE=openshift/conformance/parallel run-tests
Copy link
Copy Markdown
Contributor

@sgreene570 sgreene570 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the pipe here do?

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not supposed to change anything functionally, just to trigger an e2e-aws rehearsal here, see Clayton's comment above.

Copy link
Copy Markdown
Contributor

@sgreene570 sgreene570 Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok, just wanted to make sure that's what it was.

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(also, this is just my naive assumpion; I've seen multi-line commands written this way (with the pipe) elsewhere). It did trigger the e2e test this time, so let's see whether or not it works! =)

Copy link
Copy Markdown
Contributor

@smarterclayton smarterclayton Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

| just makes it multiline.

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will it still work with just one line?

Copy link
Copy Markdown
Contributor Author

@LorbusChris LorbusChris Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(otherwise I'll pull run-tests down in a second line)

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2019

@LorbusChris: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/fcos/e2e-aws cfcef3f link /test pj-rehearse
ci/prow/pj-rehearse cfcef3f link /test pj-rehearse

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton
Copy link
Copy Markdown
Contributor

smarterclayton commented Oct 31, 2019

Looks like the Etcd cluster never becomes healthy?

/lgtm

Let's test this here until we get greens before moving this particular change to master branch

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: LorbusChris, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 92961c3 into openshift:master Oct 31, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2019

@LorbusChris: Updated the following 3 configmaps:

  • ci-operator-misc-configs configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
  • ci-operator-misc-configs configmap in namespace ci-stg using the following files:
    • key openshift-machine-config-operator-fcos.yaml using file ci-operator/config/openshift/machine-config-operator/openshift-machine-config-operator-fcos.yaml
  • job-config-misc configmap in namespace ci using the following files:
    • key openshift-machine-config-operator-fcos-presubmits.yaml using file ci-operator/jobs/openshift/machine-config-operator/openshift-machine-config-operator-fcos-presubmits.yaml
Details

In response to this:

Build os container with MCD RPM for each PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@LorbusChris LorbusChris mentioned this pull request Nov 6, 2019
Merged
LorbusChris added a commit to LorbusChris/release that referenced this pull request Nov 25, 2019
@LorbusChris
MCD RPM and os container builds for 4.2+ branches
7a3ebbf 
Porting openshift#5659 openshift#5681 openshift#5695 to all branches from 4.2 to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericavonb ericavonb Awaiting requested review from ericavonb

@runcom runcom Awaiting requested review from runcom

3 more reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@DanyC97 DanyC97 DanyC97 left review comments

@sgreene570 sgreene570 sgreene570 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@smarterclayton smarterclayton

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@LorbusChris @smarterclayton @openshift-ci-robot @DanyC97 @sgreene570 @vrutkovs @openshift-merge-robot