Replace networkmanager scripts with podman wrappers#1521
Replace networkmanager scripts with podman wrappers#1521vrutkovs wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vrutkovs The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Do we have OpenStack e2e here? |
|
/cc @cgwalters @runcom |
|
/hold worker nodes didn't join :/ |
|
does the container maybe need to be privileged in this case? |
|
unprivildged container should work too. Its odd that workers didn't join as NotReady nodes - lets see if that is consistent /retest |
|
/retest |
|
ffs, so |
Python may not be included in base OS, so the scripts should be running from the container, instead of being placed on the host
9814088 to
148b29d
Compare
Avoid running python scripts on host and use `podman run --net=host` instead Cherrypicked to master as openshift#1521
|
/assign @rgolangh |
|
/test e2e-ovirt |
|
@vrutkovs: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
This won't work because the UBI7 containers don't have Python 3 included, as noted above by @vrutkovs. We also can't switch over to UBI8 for the baremetal-runtimecfg container base because that won't run on RHEL7, which is still supported as worker nodes in OCP. If I'm not mistaken @celebdor is working on translating the scripts to Golang, which would we be the preferred solution here anyway. This is also tracked in #1430 I believe this PR can thus be closed? |
|
I don't see this as applicable to master at this time. |
|
@LorbusChris: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
- What I did
Replaced python scripts for NetworkManager with podman wrappers
- How to verify it
Run vSphere / oVirt / Openstack IPI installs - workers should join cluster as expected
- Description for the changelog
NM helper scripts are running from podman containers
See openshift/baremetal-runtimecfg#46