Skip to content

baremetal-runtimecfg: use UBI8 as base#7391

Closed
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:bm-runtimeconfig-base
Closed

baremetal-runtimecfg: use UBI8 as base#7391
vrutkovs wants to merge 1 commit intoopenshift:masterfrom
vrutkovs:bm-runtimeconfig-base

Conversation

@vrutkovs
Copy link
Copy Markdown
Contributor

@vrutkovs vrutkovs commented Mar 1, 2020

base 4.5 is using UBI7, which has python2. Scripts are not python2
compatible, so UBI8 needs to be used so that scripts would run in
container.

Required for openshift/machine-config-operator#1521. This fixes OKD on openstack, where scripts are running in the container.

Fixes openshift/machine-config-operator#1430

/cc @celebdor

base 4.5 is using UBI7, which has python2. Scripts are not python2 
compatible, so UBI8 needs to be used so that scripts would run in 
container
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vrutkovs
To complete the pull request process, please assign cybertron
You can assign the PR to them by writing /assign @cybertron in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrutkovs vrutkovs changed the title baremetal-runtimecfg: use UBI8 as base WIP baremetal-runtimecfg: use UBI8 as base Mar 1, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2020
@vrutkovs vrutkovs changed the title WIP baremetal-runtimecfg: use UBI8 as base baremetal-runtimecfg: use UBI8 as base Mar 1, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 1, 2020
@LorbusChris
Copy link
Copy Markdown
Contributor

@vrutkovs this should probably go into 4.5 and 4.6 as well

@vrutkovs
Copy link
Copy Markdown
Contributor Author

vrutkovs commented Mar 3, 2020

/hold

probably not needed since we're going to rebase fcos branch on master soon

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 3, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor Author

/retest

@LorbusChris
Copy link
Copy Markdown
Contributor

We can't do this because we can't use UBI8 containers on RHEL7 workers. Or am I missing something?

@LorbusChris
Copy link
Copy Markdown
Contributor

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@LorbusChris: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FCOS] openstack: workers don't join the cluster due to python scripts

3 participants