Skip to content

Bug 1881137: vSphere: don't failover api vip if lb is responding#2109

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_vip_failover
Sep 22, 2020
Merged

Bug 1881137: vSphere: don't failover api vip if lb is responding#2109
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
jcpowermac:vsphere_vip_failover

Conversation

@jcpowermac
Copy link
Copy Markdown
Contributor

@jcpowermac jcpowermac commented Sep 21, 2020 •
edited
Loading

Ports #1893 to the vSphere platform.

vSphere CI is experiencing the issues described in the above
PR.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

@ashcrow ashcrow requested review from yuqi-zhang and removed request for ashcrow September 21, 2020 14:46
@jcpowermac jcpowermac changed the title [wip] vSphere: don't failover api vip if lb is responding Bug 1881137: [wip] vSphere: don't failover api vip if lb is responding Sep 21, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Sep 21, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 21, 2020

@jcpowermac: This pull request references Bugzilla bug 1881137, which is invalid:

  • expected the bug to target the "4.6.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1881137: [wip] vSphere: don't failover api vip if lb is responding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 21, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 21, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 21, 2020

@jcpowermac: This pull request references Bugzilla bug 1881137, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

I tested manually and doesn't experience the same issue.

@yuqi-zhang
Copy link
Copy Markdown
Contributor

yuqi-zhang commented Sep 21, 2020

The PR you linked #1892 is a closed debug PR. Were you trying to link something else?

/approve tentatively, let's see if we can get CI to pass

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

The PR you linked #1892 is a closed debug PR. Were you trying to link something else?

/approve tentatively, let's see if we can get CI to pass

Yeah it was supposed to be: #1893

@jcpowermac jcpowermac changed the title Bug 1881137: [wip] vSphere: don't failover api vip if lb is responding [wip] Bug 1881137: vSphere: don't failover api vip if lb is responding Sep 21, 2020
@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 21, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 21, 2020

/test e2e-vsphere

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 22, 2020

@jcpowermac: This pull request references Bugzilla bug 1881137, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

[wip] Bug 1881137: vSphere: don't failover api vip if lb is responding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac
vSphere: don't failover api vip if lb is responding
018e66f 
Ports openshift#1893 to the vSphere platform.

vSphere CI is experiencing the issues described in the above
PR.
@jcpowermac jcpowermac changed the title [wip] Bug 1881137: vSphere: don't failover api vip if lb is responding Bug 1881137: vSphere: don't failover api vip if lb is responding Sep 22, 2020
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 22, 2020

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 22, 2020

The test failures in vsphere are not related to this PR.
@jhixson74 @abhinavdahiya ptal

/test e2e-vsphere

@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 22, 2020

Manually tested as well. No install issues.

cgwalters
cgwalters approved these changes Sep 22, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

This is another thing we should start generating rather than templating so the code is shared.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 22, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jcpowermac, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,yuqi-zhang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 22, 2020
@jcpowermac
Copy link
Copy Markdown
Contributor Author

jcpowermac commented Sep 22, 2020

/test e2e-aws

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Sep 22, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8955fa5 into openshift:master Sep 22, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Sep 22, 2020

@jcpowermac: All pull requests linked via external trackers have merged:

Bugzilla bug 1881137 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1881137: vSphere: don't failover api vip if lb is responding

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jcpowermac jcpowermac mentioned this pull request Sep 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@cgwalters cgwalters

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jcpowermac @openshift-ci-robot @yuqi-zhang @openshift-bot @cgwalters @openshift-merge-robot