Bug 1881137: vsphere - update haproxy interval by jcpowermac · Pull Request #2130 · openshift/machine-config-operator

jcpowermac · 2020-09-30T20:22:44Z

When updating vSphere for baremetal changes
of keepalived and haproxy I missed the interval change
for haproxy backend masters.

When updating vSphere for baremetal changes of keepalived and haproxy I missed the interval change for haproxy backend masters.

jcpowermac · 2020-09-30T20:25:17Z

Related to: #2109
And #2075

jcpowermac · 2020-09-30T20:26:06Z

/test e2e-vsphere

openshift-ci-robot · 2020-09-30T21:14:56Z

@jcpowermac: This pull request references Bugzilla bug 1881137, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[wip] Bug 1881137: vsphere - update haproxy interval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2020-09-30T21:15:53Z

/bugzilla refresh

openshift-ci-robot · 2020-09-30T21:15:57Z

@jcpowermac: This pull request references Bugzilla bug 1881137, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.0) matches configured target release for branch (4.6.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jcpowermac · 2020-09-30T21:34:13Z

Manually tested install completed without issues:

DEBUG Cluster is initialized                                                                                                                                                                                                                                                   
INFO Waiting up to 10m0s for the openshift-console route to be created...                                                                                                                                                                                                      
DEBUG Route found in openshift-console namespace: console                                                                                                                                                                                                                      
DEBUG Route found in openshift-console namespace: downloads                                                                                                                                                                                                                    
DEBUG OpenShift console route is created                                                                                                                                                                                                                                       
INFO Install complete!                                                                                                                                                                                                                                                         
INFO To access the cluster as the system:admin user when using 'oc', run 'export KUBECONFIG=/projects/installer-testing/vsphere-ipi/auth/kubeconfig'                                                                                                                           
INFO Access the OpenShift web-console here: https://console-openshift-console.apps.jcallen.vmc.devcluster.openshift.com                                                                                                                                                        
                                                                                                                                                                              
DEBUG Time elapsed per stage:                                                                                                                                                                                                                                                  
DEBUG     Infrastructure: 1m19s                                                                                                                                                                                                                                                
DEBUG Bootstrap Complete: 8m43s                                                                                                                                                                                                                                                
DEBUG                API: 2m5s                                                                                                                                                                                                                                                 
DEBUG  Bootstrap Destroy: 16s                                                                                                                                                                                                                                                  
DEBUG  Cluster Operators: 30m5s                                                                                                                                                                                                                                                
INFO Time elapsed: 40m30s

Failing test:

[sig-arch] Managed cluster should have no crashlooping pods in core namespaces over four minutes [Suite:openshift/conformance/parallel]

error: 2 fail, 971 pass, 1448 skip (19m55s)

kikisdeliveryservice · 2020-09-30T23:07:32Z

@jcpowermac do we... expect the e2e to pass?

jcpowermac · 2020-09-30T23:18:52Z

@jcpowermac do we... expect the e2e to pass?

@kikisdeliveryservice I am good with the single failure. Lately if vsphere installs its a win ;-)

jcpowermac · 2020-09-30T23:46:54Z

@cybertron can you ptal, updating per: #2075

cc: @sdodson

sdodson · 2020-10-01T15:58:12Z

/lgtm

openshift-ci-robot · 2020-10-01T15:58:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jcpowermac, kikisdeliveryservice, sdodson

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

sdodson · 2020-10-01T15:58:48Z

Confirmed this brings the two templates inline with each other.

cybertron · 2020-10-01T17:03:45Z

Yep, lgtm. The keepalived interval is already correct so this should be all that is needed.

openshift-bot · 2020-10-01T17:05:14Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-10-01T17:18:12Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-01T18:59:33Z

@jcpowermac: The following test failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi	`ca8da62`	link	`/test e2e-metal-ipi`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2020-10-01T19:15:17Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-10-01T19:17:52Z

@jcpowermac: All pull requests linked via external trackers have merged:

Bugzilla bug 1881137 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1881137: vsphere - update haproxy interval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

vsphere - update haproxy interval

ca8da62

When updating vSphere for baremetal changes of keepalived and haproxy I missed the interval change for haproxy backend masters.

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2020

openshift-ci-robot requested review from kikisdeliveryservice and sinnykumari September 30, 2020 20:23

jcpowermac changed the title ~~[wip] vsphere - update haproxy interval~~ [wip] Bug 1881137: vsphere - update haproxy interval Sep 30, 2020

openshift-ci-robot added the bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. label Sep 30, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 30, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Sep 30, 2020

jcpowermac changed the title ~~[wip] Bug 1881137: vsphere - update haproxy interval~~ Bug 1881137: vsphere - update haproxy interval Sep 30, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 30, 2020

kikisdeliveryservice approved these changes Sep 30, 2020

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2020

openshift-ci-robot assigned sdodson Oct 1, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2020

openshift-merge-robot merged commit 22a4a27 into openshift:master Oct 1, 2020

Conversation

jcpowermac commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

openshift-ci-robot commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

kikisdeliveryservice commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

jcpowermac commented Sep 30, 2020

Uh oh!

sdodson commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

sdodson commented Oct 1, 2020

Uh oh!

cybertron commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

openshift-bot commented Oct 1, 2020

Uh oh!

openshift-ci-robot commented Oct 1, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants