Skip to content

[release-4.6] Bug 1888853: daemon: allow an extension to install group of packages#2173

Closed
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-2170-to-release-4.6
Closed

[release-4.6] Bug 1888853: daemon: allow an extension to install group of packages#2173
openshift-cherrypick-robot wants to merge 1 commit intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-2170-to-release-4.6

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

This is an automated cherry-pick of #2170

/assign sinnykumari

In the previous implementation, an extension was one to one
mapping with the package it would install on the host. This can
become confusing if enabling an extension would require
installing multiple sets of packages which are not install
time dependency.

Also added e2e test for kernel-devel extensions
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: Detected clone of Bugzilla bug 1890074 with correct target release. Retitling PR to link to clone:
/retitle [release-4.6] Bug 1888853: daemon: allow an extension to install group of packages

Details

In response to this:

[release-4.6] Bug 1890074: daemon: allow an extension to install group of packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1890074: daemon: allow an extension to install group of packages [release-4.6] Bug 1888853: daemon: allow an extension to install group of packages Oct 23, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 23, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1888853, which is invalid:

  • expected dependent Bugzilla bug 1890074 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1888853: daemon: allow an extension to install group of packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 23, 2020
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-upgrade d8fe801 link /test okd-e2e-upgrade
ci/prow/okd-e2e-gcp-op d8fe801 link /test okd-e2e-gcp-op
ci/prow/okd-e2e-aws d8fe801 link /test okd-e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Copy Markdown
Member

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straightforward cherry pick, low risk.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2020
@vrutkovs
Copy link
Copy Markdown
Contributor

This breaks OKD - it duplicates the check for extensions, where its not supposed to be checked

@sinnykumari
Copy link
Copy Markdown
Contributor

closing in favor of #2187 that contains OKD fixes too
/clsoe

@sinnykumari
Copy link
Copy Markdown
Contributor

/close

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@sinnykumari: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants