Skip to content

Bug 1888853: daemon: allow an extension to install group of packages#2187

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.6from
sinnykumari:extension-kernel-devel
Nov 14, 2020
Merged

Bug 1888853: daemon: allow an extension to install group of packages#2187
openshift-merge-robot merged 2 commits intoopenshift:release-4.6from
sinnykumari:extension-kernel-devel

Conversation

@sinnykumari
Copy link
Copy Markdown
Contributor

@sinnykumari sinnykumari commented Oct 28, 2020 •
edited
Loading

@sinnykumari
daemon: allow an extension to install group of packages
d23173f 
In the previous implementation, an extension was one to one
mapping with the package it would install on the host. This can
become confusing if enabling an extension would require
installing multiple sets of packages which are not install
time dependency.

Also added e2e test for kernel-devel extensions
@sinnykumari
daemon: allow one to one mapping of extension on OKD
b279b2f 
FCOS does one to one mapping of extension to package
to be installed on FCOS node. This is needed as OKD
layers additional packages on top of official FCOS shipped,
See https://github.com/openshift/release/blob/959c2954344438c4eed3ec7f52a5e099e8335516/ci-operator/jobs/openshift/release/openshift-release-release-4.7-periodics.yaml#L586

In future, once the package list has been stabilized,
we can make use of the group and add all the packages required
to enable OKD as a single extension.
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 28, 2020

@sinnykumari: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Extension kernel devel

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 28, 2020
@sinnykumari sinnykumari changed the title Extension kernel devel [release-4.6] Bug 1888853: daemon: allow an extension to install group of packages Oct 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 28, 2020

@sinnykumari: This pull request references Bugzilla bug 1888853, which is invalid:

  • expected dependent Bugzilla bug 1890074 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1888853: daemon: allow an extension to install group of packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 28, 2020
@sinnykumari sinnykumari mentioned this pull request Oct 28, 2020
Closed
@sinnykumari sinnykumari requested a review from vrutkovs October 28, 2020 10:37
@sinnykumari
Copy link
Copy Markdown
Contributor Author

sinnykumari commented Oct 28, 2020

@vrutkovs are these OKD test failure expected?

@vrutkovs
Copy link
Copy Markdown
Contributor

vrutkovs commented Oct 28, 2020

/retest

@vrutkovs vrutkovs mentioned this pull request Oct 28, 2020
Closed
6 tasks
@vrutkovs
Copy link
Copy Markdown
Contributor

vrutkovs commented Oct 28, 2020 •
edited
Loading

GCP installs in 4.6 is blocked by coreos/fedora-coreos-tracker#649.

OKD AWS reached test phase and failed on flaking tests. Lets run this again and then /skip if it still fails.

Thanks for taking care of that!

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Oct 28, 2020

as per @vrutkovs post above, skipping the failed okd tests

/skip

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Oct 28, 2020

Since this needs the OG BZ verified first, will let @vrutkovs do the final lgtm, but LGTM. 😸

/assign @vrutkovs

@vrutkovs
Copy link
Copy Markdown
Contributor

vrutkovs commented Oct 29, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, vrutkovs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kikisdeliveryservice kikisdeliveryservice added the 4.6 Work targeted for 4.6 label Oct 29, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 30, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 30, 2020

@openshift-bot: This pull request references Bugzilla bug 1888853, which is invalid:

  • expected dependent Bugzilla bug 1890074 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Oct 31, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2020

@openshift-bot: This pull request references Bugzilla bug 1888853, which is invalid:

  • expected dependent Bugzilla bug 1890074 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 1, 2020

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 1, 2020

@openshift-bot: This pull request references Bugzilla bug 1888853, which is invalid:

  • expected dependent Bugzilla bug 1890074 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

24 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 12, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 13, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Nov 13, 2020 •
edited
Loading

@sinnykumari: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-gcp-op b279b2f link /test okd-e2e-gcp-op
ci/prow/okd-e2e-upgrade b279b2f link /test okd-e2e-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Nov 13, 2020 •
edited
Loading

Overriding gcp-op in this case for one time only:

  1. the pr itself did have a passing run in 4.6 gcp-op and is still on the same commit

  2. only 1 relevant backport was added to 4.6 since that point in time and that commit has coexisted with the 4.7 version of this pr and had passing runs so i have no reason to think they are incompatible.

For this special case due to urgency:
/override ci/prow/e2e-gcp-op

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 13, 2020

@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-gcp-op

Details

In response to this:

Overriding gcp-op in this case for one time only:

  1. the pr itself did have a passing run in 4.6 gcp-op and is still on the same commit 2) only 1 relevant backport was added to 4.6 since that point in time and that commit has coexisted with the 4.7 version of this pr and had passing runs so i have no reason to think they are incompatible.

For this special case due to urgency:
/override ci/prow/e2e-gcp-op

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot openshift-merge-robot merged commit fbb7093 into openshift:release-4.6 Nov 14, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 14, 2020

@sinnykumari: All pull requests linked via external trackers have merged:

Bugzilla bug 1888853 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1888853: daemon: allow an extension to install group of packages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters Awaiting requested review from cgwalters

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

1 more reviewer

@vrutkovs vrutkovs vrutkovs approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ashcrow ashcrow

@vrutkovs vrutkovs

Labels

4.6 Work targeted for 4.6 approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@sinnykumari @openshift-ci-robot @vrutkovs @kikisdeliveryservice @openshift-bot @ashcrow @sdodson @openshift-merge-robot