Skip to content

[release-4.6] Bug 1893483: vendor in drain fix for using high cpu#2193

Merged
openshift-merge-robot merged 2 commits intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-2191-to-release-4.6
Nov 6, 2020
Merged

[release-4.6] Bug 1893483: vendor in drain fix for using high cpu#2193
openshift-merge-robot merged 2 commits intoopenshift:release-4.6from
openshift-cherrypick-robot:cherry-pick-2191-to-release-4.6

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Oct 31, 2020

This is an automated cherry-pick of #2191

/assign rphillips

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Oct 31, 2020
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2020

@openshift-cherrypick-robot: Bugzilla bug 1889912 has been cloned as Bugzilla bug 1893483. Retitling PR to link against new bug.
/retitle [release-4.6] Bug 1893483: vendor in drain fix for using high cpu

Details

In response to this:

[release-4.6] Bug 1889912: vendor in drain fix for using high cpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.6] Bug 1889912: vendor in drain fix for using high cpu [release-4.6] Bug 1893483: vendor in drain fix for using high cpu Oct 31, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Oct 31, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Oct 31, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1893483, which is invalid:

  • expected dependent Bugzilla bug 1889912 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] Bug 1893483: vendor in drain fix for using high cpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Oct 31, 2020
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Nov 2, 2020

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2020
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

14 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 2, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 5, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

19 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Nov 6, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Nov 6, 2020

/override ci/prow/e2e-gcp-op
/override ci/prow/okd-e2e-upgrade

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Nov 6, 2020

Hm crap I didn't mean to override e2e-gcp-op; I got that mixed up with the okd one.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 6, 2020

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-gcp-op, ci/prow/okd-e2e-upgrade

Details

In response to this:

/override ci/prow/e2e-gcp-op
/override ci/prow/okd-e2e-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Nov 6, 2020

Offhand it looks like e2e-gcp-op is hitting timeouts even in 4.6 which is concerning.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Nov 6, 2020

This change is pretty clearly safe at least.
Let me see if this will undo the override...I'd like to see if we can get it to pass in 4.6
/test e2e-gcp-op

@openshift-merge-robot openshift-merge-robot merged commit acf0188 into openshift:release-4.6 Nov 6, 2020
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 6, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1893483 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.6] Bug 1893483: vendor in drain fix for using high cpu

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rphillips
Copy link
Copy Markdown
Contributor

rphillips commented Nov 9, 2020

/cherry-pick release-4.5

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

openshift-cherrypick-robot commented Nov 9, 2020

@rphillips: #2193 failed to apply on top of branch "release-4.5":

Applying: update kubectl for drain fix
Using index info to reconstruct a base tree...
M	go.mod
Falling back to patching base and 3-way merge...
Auto-merging go.mod
CONFLICT (content): Merge conflict in go.mod
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 update kubectl for drain fix
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
Details

In response to this:

/cherry-pick release-4.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kikisdeliveryservice kikisdeliveryservice mentioned this pull request Nov 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgwalters cgwalters cgwalters approved these changes

@runcom runcom Awaiting requested review from runcom

@sinnykumari sinnykumari Awaiting requested review from sinnykumari

Assignees

@rphillips rphillips

@sinnykumari sinnykumari

Labels

4.6 Work targeted for 4.6 approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@openshift-cherrypick-robot @openshift-ci-robot @sinnykumari @openshift-bot @cgwalters @rphillips @sdodson @kikisdeliveryservice @openshift-merge-robot