Skip to content

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used#2494

Merged
openshift-merge-robot merged 1 commit into
openshift:masterfrom
harche:bug_1941936
Mar 29, 2021
Merged

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used#2494
openshift-merge-robot merged 1 commit into
openshift:masterfrom
harche:bug_1941936

Conversation

@harche
Copy link
Copy Markdown
Contributor

@harche harche commented Mar 29, 2021

Signed-off-by: Harshal Patil harpatil@redhat.com

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1941936
- What I did
Made LogSizeMax and OverlaySize in ContainerRuntimeConfiguration omit when not used.

- How to verify it
https://bugzilla.redhat.com/show_bug.cgi?id=1941936#c0

- Description for the changelog

Drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@harche: This pull request references Bugzilla bug 1941936, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

Bug 1941936: drop LogSizeMax and LogSizeMax in ContainrConfig when not used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 29, 2021
@harche
Copy link
Copy Markdown
Contributor Author

harche commented Mar 29, 2021

/hold

Testing is still under progress.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2021
@harche harche changed the title Bug 1941936: drop LogSizeMax and LogSizeMax in ContainrConfig when not used Bug 1941936: drop LogSizeMax and OverlaySize in ContainrConfig when not used Mar 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@harche: This pull request references Bugzilla bug 1941936, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

Bug 1941936: drop LogSizeMax and OverlaySize in ContainrConfig when not used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Harshal Patil <harpatil@redhat.com>
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@harche: This pull request references Bugzilla bug 1941936, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

Bug 1941936: drop LogSizeMax and OverlaySize in ContainrConfig when not used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche harche changed the title Bug 1941936: drop LogSizeMax and OverlaySize in ContainrConfig when not used Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used Mar 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@harche: This pull request references Bugzilla bug 1941936, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (schoudha@redhat.com), skipping review request.

Details

In response to this:

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@harche
Copy link
Copy Markdown
Contributor Author

harche commented Mar 29, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 29, 2021
@rphillips
Copy link
Copy Markdown
Contributor

/lgtm
/approve
/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 29, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 29, 2021

@harche: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/okd-e2e-aws 60ba3d8 link /test okd-e2e-aws
ci/prow/e2e-metal-ipi 60ba3d8 link /test e2e-metal-ipi
ci/prow/e2e-ovn-step-registry 60ba3d8 link /test e2e-ovn-step-registry
ci/prow/e2e-aws-workers-rhel7 60ba3d8 link /test e2e-aws-workers-rhel7

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2021
@openshift-merge-robot openshift-merge-robot merged commit 63d8209 into openshift:master Mar 29, 2021
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@harche: All pull requests linked via external trackers have merged:

Bugzilla bug 1941936 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants