Skip to content

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-robot merged 1 commit into from
Mar 29, 2021
Merged

Bug 1941936: drop LogSizeMax and OverlaySize in ContainerRuntimeConfiguration when not used #2494

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/apis/machineconfiguration.openshift.io/v1/types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -448,11 +448,11 @@ type ContainerRuntimeConfiguration struct {
// logSizeMax specifies the Maximum size allowed for the container log file.
// Negative numbers indicate that no size limit is imposed.
// If it is positive, it must be >= 8192 to match/exceed conmon's read buffer.
LogSizeMax resource.Quantity `json:"logSizeMax"`
LogSizeMax resource.Quantity `json:"logSizeMax,omitempty"`

// overlaySize specifies the maximum size of a container image.
// This flag can be used to set quota on the size of container images. (default: 10GB)
OverlaySize resource.Quantity `json:"overlaySize"`
OverlaySize resource.Quantity `json:"overlaySize,omitempty"`
}

// ContainerRuntimeConfigStatus defines the observed state of a ContainerRuntimeConfig
Expand Down