Skip to content

Bug 1957972: Remove remnants of mdns functionality#2571

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cybertron:mdns-cleanup
May 21, 2021
Merged

Bug 1957972: Remove remnants of mdns functionality#2571
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cybertron:mdns-cleanup

Conversation

@cybertron
Copy link
Copy Markdown
Member

@cybertron cybertron commented May 6, 2021

mDNS was removed in #2465, but a couple of the related templates were
missed. This just cleans those up too.

Note that there are also references to mdns in the MCO code, but I'm going
to leave the removal of those until 4.9 so we don't risk breaking anything on
upgrade.

@cybertron
Remove remnants of mdns functionality
4e41bb5 
mDNS was removed in openshift#2465, but a couple of the related templates were
missed. This just cleans those up too.
@openshift-ci openshift-ci Bot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2021

@cybertron: This pull request references Bugzilla bug 1957972, which is invalid:

  • expected the bug to target the "4.8.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1957972: Remove remnants of mdns functionality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from celebdor and hardys May 6, 2021 21:28
@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 6, 2021

/bugzilla refresh

@openshift-ci openshift-ci Bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 6, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 6, 2021

@cybertron: This pull request references Bugzilla bug 1957972, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (vvoronko@redhat.com), skipping review request.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 7, 2021

/retest

2 similar comments
@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 10, 2021

/retest

@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 12, 2021

/retest

@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 13, 2021

/test e2e-openstack
/test e2e-ovirt
/test e2e-vsphere
/cc @mandre @Gal-Zaidman @jcpowermac @patrickdillon

@cybertron
Copy link
Copy Markdown
Member Author

cybertron commented May 19, 2021

/test e2e-vsphere

mandre
mandre reviewed May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see all the related CI jobs have passed.
/lgtm

On a side note, we should also merge openshift/installer#4821

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2021
@mandre
Copy link
Copy Markdown
Member

mandre commented May 21, 2021

Per the bot suggestion, assigning Kirsten for approval.
/assign @kikisdeliveryservice

kikisdeliveryservice
kikisdeliveryservice approved these changes May 21, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@kikisdeliveryservice kikisdeliveryservice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, kikisdeliveryservice, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 21, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented May 21, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 502eae1 into openshift:master May 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 21, 2021

@cybertron: All pull requests linked via external trackers have merged:

Bugzilla bug 1957972 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1957972: Remove remnants of mdns functionality

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@celebdor celebdor Awaiting requested review from celebdor

@hardys hardys Awaiting requested review from hardys

@Gal-Zaidman Gal-Zaidman Awaiting requested review from Gal-Zaidman

@jcpowermac jcpowermac Awaiting requested review from jcpowermac

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

2 more reviewers

@mandre mandre mandre left review comments

@kikisdeliveryservice kikisdeliveryservice kikisdeliveryservice approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cybertron @mandre @openshift-bot @kikisdeliveryservice @openshift-merge-robot