Skip to content

Update github.com/containers/image#2695

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mtrmac:c-image-deps
Apr 4, 2022
Merged

Update github.com/containers/image#2695
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
mtrmac:c-image-deps

Conversation

@mtrmac
Copy link
Copy Markdown
Contributor

@mtrmac mtrmac commented Jul 27, 2021 •
edited
Loading

- What I did

Update github.com/containers/image to remove a lot of the c/storage dependencies added in #2689 .

This is vendoring an unreleased version of c/image; a release should happen soon, filing this now so that I don't forget.

- How to verify it

Existing CI

- Description for the changelog
Removed some dependencies to decrease size of the built binary and compilation time.

@mtrmac mtrmac mentioned this pull request Jul 27, 2021
Merged
@umohnani8
Copy link
Copy Markdown
Contributor

umohnani8 commented Jul 27, 2021

LGTM
Thanks @mtrmac!

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Jul 27, 2021

Thanks for the PR, love that this reduces deps.
Shall we put hold on this PR until c/image gets released with the desired version we want?

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Jul 27, 2021

/retest

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Jul 27, 2021

Thanks for the PR, love that this reduces deps.
Shall we put hold on this PR until c/image gets released with the desired version we want?

Same question as @sinnykumari

But as a note: this is my favorite type of PR ❤️

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Jul 28, 2021

Thanks for the PR, love that this reduces deps.
Shall we put hold on this PR until c/image gets released with the desired version we want?

Same question as @sinnykumari

That’s up to the maintainers of this project :) FWIW a release should happen within a week.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Jul 28, 2021

/retest

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Jul 28, 2021

Putting hold until we update deps to released c/image
/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 28, 2021
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Jul 30, 2021

/hold cancel

Updated to use released containers/image v5.15.0 now.

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 30, 2021
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 2, 2021

/retest

sinnykumari
sinnykumari approved these changes Aug 2, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sinnykumari sinnykumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet 🎉

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Aug 2, 2021

/retest

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2021
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 2, 2021

/retest

1 similar comment
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 3, 2021

/retest

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

kikisdeliveryservice commented Aug 3, 2021

Do we think there's an issue with this PR wrt to e2e-agnostic-upgrade, bc it seems to be consistnelty failing on the last push to this PR:
https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=2695

OTOH the test also seems red for the last few days but not enough runs to tell

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 9, 2021

Do we think there's an issue with this PR wrt to e2e-agnostic-upgrade, bc it seems to be consistnelty failing on the last push to this PR:
https://prow.ci.openshift.org/pr-history/?org=openshift&repo=machine-config-operator&pr=2695

I’m honestly not sure. It is admittedly somewhat suggestive that each of the 5 recently-failing tests seems to be failing somewhat consistently over time, but each differently from the others.

At least the e2e-agnostic-upgrade failures about

event happened … times, something is wrong: ns/openshift-machine-api machine/… - reason/Updated Updated machine "…"

are likely openshift/cluster-api-provider-azure#227 .

I’ll try to look into the root causes of the other consistent failures tomorrow.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 10, 2021

The e2e-aws-disruptive

pods/openshift-insights_insights-operator-59d9d555c7-9k9sg_insights-operator.log.gz:E0730 13:30:37.574968       1 runtime.go:78] Observed a panic: "invalid memory address or nil pointer dereference" (runtime error: invalid memory address or nil pointer dereference)

seems to be openshift/insights-operator#484 , though why the API is not available is a different matter.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 11, 2021 •
edited
Loading

e2e-aws-techpreview-featuregate

fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: Aug  2 20:20:55.119: Some cluster operators are not ready: kube-apiserver (Upgradeable=False FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade: FeatureGatesUpgradeable: "TechPreviewNoUpgrade" does not allow updates)

is openshift/release#20554 , or whatever happened to it.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 11, 2021 •
edited
Loading

is openshift/release#20554 , or whatever happened to it.

that’s openshift/origin#26349 .

Anyway, I’m out of low-hanging fruit and over a week has passed, let’s try again to see if maybe someone else fixed the other problems.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Aug 11, 2021

/retest

1 similar comment
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Aug 12, 2021

/retest

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 16, 2021
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 18, 2021
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

8 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 29, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Mar 30, 2022

/retest

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 30, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Mar 31, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 31, 2022
@mtrmac
Update github.com/containers/image
9ffab24 
... to remove a lot of the c/storage dependencies added in
openshift#2689 .

Signed-off-by: Miloslav Trmač <mitr@redhat.com>
@openshift-ci openshift-ci Bot removed lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Mar 31, 2022
@mtrmac
Copy link
Copy Markdown
Contributor Author

mtrmac commented Apr 4, 2022

/retest

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2022 •
edited
Loading

@mtrmac: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-upgrade-single-node 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-aws-upgrade-single-node
ci/prow/e2e-vsphere-upgrade 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-disruptive 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-aws-disruptive
ci/prow/e2e-gcp-op-single-node 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-gcp-op-single-node
ci/prow/e2e-metal-ipi 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-metal-ipi
ci/prow/e2e-aws-workers-rhel7 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 58e9594404e601db3506933756afb3b85bb270ae link false /test e2e-aws-workers-rhel8
ci/prow/4.12-upgrade-from-stable-4.11-images c91e5bd3fce20174532c77eb8c5c7c7cf27b089c link true /test 4.12-upgrade-from-stable-4.11-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Apr 4, 2022

The failures are all known flakes.
/override ci/prow/e2e-agnostic-upgrade

@cgwalters
Copy link
Copy Markdown
Member

cgwalters commented Apr 4, 2022

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2022

@cgwalters: Overrode contexts on behalf of cgwalters: ci/prow/e2e-agnostic-upgrade

Details

In response to this:

The failures are all known flakes.
/override ci/prow/e2e-agnostic-upgrade

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, kikisdeliveryservice, mtrmac, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,kikisdeliveryservice,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 5516bd8 into openshift:master Apr 4, 2022
@mtrmac mtrmac deleted the c-image-deps branch April 4, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sinnykumari sinnykumari sinnykumari approved these changes

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@cgwalters cgwalters

@kikisdeliveryservice kikisdeliveryservice

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mtrmac @umohnani8 @sinnykumari @kikisdeliveryservice @openshift-bot @cgwalters @openshift-merge-robot