Skip to content

Account for upgrade blocking operator during tech preview#20554

Closed
JoelSpeed wants to merge 1 commit intoopenshift:masterfrom
JoelSpeed:skip-check-operators
Closed

Account for upgrade blocking operator during tech preview#20554
JoelSpeed wants to merge 1 commit intoopenshift:masterfrom
JoelSpeed:skip-check-operators

Conversation

@JoelSpeed
Copy link
Copy Markdown
Contributor

When the techpreview feature gate is installed, the Kube API server operator blocks upgrades. This causes this test to fail which means this suite will never pass. We need to ignore this test for this workflow.

eg from https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_machine-config-operator/2668/pull-ci-openshift-machine-config-operator-master-e2e-aws-techpreview-featuregate/1418130262688010240

fail [github.com/onsi/ginkgo@v4.7.0-origin.0+incompatible/internal/leafnodes/runner.go:113]: Jul 22 09:33:54.305: Some cluster operators are not ready: kube-apiserver (Upgradeable=False FeatureGates_RestrictedFeatureGates_TechPreviewNoUpgrade: FeatureGatesUpgradeable: "TechPreviewNoUpgrade" does not allow updates)

@openshift-ci openshift-ci Bot requested review from vrutkovs and wking July 23, 2021 13:10
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 23, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoelSpeed
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 23, 2021

@JoelSpeed: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Rerun command
ci/rehearse/openshift/machine-config-operator/release-4.9/e2e-aws-techpreview-featuregate f8b4622 link /test pj-rehearse
ci/prow/pj-rehearse f8b4622 link /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs
Copy link
Copy Markdown
Contributor

I'd prefer origin tests to have a switch to ignore TechPreview error messages in that test. Otherwise we may miss some unrelated error due to this skip

@JoelSpeed
Copy link
Copy Markdown
Contributor Author

I'd prefer origin tests to have a switch to ignore TechPreview error messages in that test. Otherwise we may miss some unrelated error due to this skip

Ack, I can take a look into that instead, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants