Skip to content

updateKernelArgs: pass kargs instead of MCs#3053

Merged
openshift-merge-robot merged 1 commit intoopenshift:layeringfrom
mkenigs:refactor-updateKernelArguments
Mar 31, 2022
Merged

updateKernelArgs: pass kargs instead of MCs#3053
openshift-merge-robot merged 1 commit intoopenshift:layeringfrom
mkenigs:refactor-updateKernelArguments

Conversation

@mkenigs
Copy link
Copy Markdown
Contributor

@mkenigs mkenigs commented Mar 31, 2022

This is a refactor to allow reusing updateKernelArgs() for layering. It
is a minor improvement for master since it better protects
MachineConfigs from unintended modification by updateKernelArgs(), and
it simplifies test code which doesn't have to create dummy
MachineConfigs

This is a refactor to allow reusing updateKernelArgs() for layering. It
is a minor improvement for master since it better protects
MachineConfigs from unintended modification by updateKernelArgs(), and
it simplifies test code which doesn't have to create dummy
MachineConfigs
@mkenigs mkenigs force-pushed the refactor-updateKernelArguments branch from c484cf7 to c113a34 Compare March 31, 2022 20:08
@cgwalters
Copy link
Copy Markdown
Member

Yep, no argument here!
/approve
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 31, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, mkenigs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 31, 2022
@mkenigs
Copy link
Copy Markdown
Contributor Author

mkenigs commented Mar 31, 2022

/cherry-pick master

@openshift-cherrypick-robot
Copy link
Copy Markdown

@mkenigs: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you.

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 31, 2022

@mkenigs: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-single-node c113a34 link false /test e2e-gcp-op-single-node
ci/prow/e2e-aws-upgrade c113a34 link false /test e2e-aws-upgrade
ci/prow/e2e-gcp-single-node c113a34 link false /test e2e-gcp-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 9b886c7 into openshift:layering Mar 31, 2022
@mkenigs mkenigs deleted the refactor-updateKernelArguments branch March 31, 2022 22:40
@openshift-cherrypick-robot
Copy link
Copy Markdown

@mkenigs: new pull request created: #3055

Details

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants