updateKernelArgs: pass kargs instead of MCs#3053
updateKernelArgs: pass kargs instead of MCs#3053openshift-merge-robot merged 1 commit intoopenshift:layeringfrom
Conversation
This is a refactor to allow reusing updateKernelArgs() for layering. It is a minor improvement for master since it better protects MachineConfigs from unintended modification by updateKernelArgs(), and it simplifies test code which doesn't have to create dummy MachineConfigs
c484cf7 to
c113a34
Compare
|
Yep, no argument here! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, mkenigs The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick master |
|
@mkenigs: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@mkenigs: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mkenigs: new pull request created: #3055 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a refactor to allow reusing updateKernelArgs() for layering. It
is a minor improvement for master since it better protects
MachineConfigs from unintended modification by updateKernelArgs(), and
it simplifies test code which doesn't have to create dummy
MachineConfigs