[master] updateKernelArgs: pass kargs instead of MCs#3055

Merged

openshift-merge-robot merged 1 commit intoopenshift:masterfrom

openshift-cherrypick-robot:cherry-pick-3053-to-master

Apr 13, 2022

openshift-cherrypick-robot commented Mar 31, 2022

This is an automated cherry-pick of #3053

/assign mkenigs


          updateKernelArgs: pass kargs instead of MCs

8d81572

This is a refactor to allow reusing updateKernelArgs() for layering. It
is a minor improvement for master since it better protects
MachineConfigs from unintended modification by updateKernelArgs(), and
it simplifies test code which doesn't have to create dummy
MachineConfigs

openshift-cherrypick-robot mentioned this pull request

updateKernelArgs: pass kargs instead of MCs #3053

Merged

openshift-ci Bot assigned mkenigs

openshift-ci Bot requested review from cgwalters and kikisdeliveryservice

March 31, 2022 22:42

Member

cgwalters commented Apr 4, 2022

/approve

openshift-ci Bot added the approved label

Member

cgwalters commented Apr 12, 2022

/lgtm

openshift-ci Bot assigned cgwalters

openshift-ci Bot added the lgtm label

Contributor

openshift-ci Bot commented Apr 12, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Contributor

openshift-bot commented Apr 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

9 similar comments

Contributor

openshift-bot commented Apr 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 12, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-bot commented Apr 13, 2022

/retest-required

Please review the full test history for this PR and help us cut down flakes.

Contributor

openshift-ci Bot commented Apr 13, 2022

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-merge-robot merged commit 377b4d2 into openshift:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels