Bug 2099664: daemon: initialize nodewriter before login monitor#3211
Bug 2099664: daemon: initialize nodewriter before login monitor#3211openshift-ci[bot] merged 1 commit intoopenshift:masterfrom
Conversation
As part of openshift#3143 we re-ordered the clusterconnect operations. This meant that the login monitor started before the nodewriter object was initialized, which caused a race where the monitor could try to write the ssh accessed annotation before the nodewriter was initialized, causing a panic. This is good to get fixed, but also note that: 1. this is relatively rare since most users should not be ssh'ing 2. the general ssh accessed annotation is broken such that its not always applied, but we definitely should not panic here.
openshift-ci
Bot
added
bugzilla/severity-high
|
@yuqi-zhang: This pull request references Bugzilla bug 2099664, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
approved
|
/lgtm |
jkyros
left a comment
jkyros
left a comment
There was a problem hiding this comment.
Looks good. It's still weird that the LoginMonitor runs during the unit tests, but at least it won't panic anymore. (Not even remotely saying this should be held to fix the test, just remarking for posterity).
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, jkyros, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this is due to the branching not happening in RHCOS yet |
|
/retest |
|
@yuqi-zhang: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@yuqi-zhang: All pull requests linked via external trackers have merged: Bugzilla bug 2099664 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.11 |
|
@yuqi-zhang: new pull request created: #3219 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
5 participants
As part of #3143
we re-ordered the clusterconnect operations. This meant that the login
monitor started before the nodewriter object was initialized, which
caused a race where the monitor could try to write the ssh accessed
annotation before the nodewriter was initialized, causing a panic.
This is good to get fixed, but also note that:
always applied, but we definitely should not panic here.