Skip to content

[release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor#3219

Merged
openshift-ci[bot] merged 1 commit intoopenshift:release-4.11from
openshift-cherrypick-robot:cherry-pick-3211-to-release-4.11
Jul 6, 2022
Merged

[release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor#3219
openshift-ci[bot] merged 1 commit intoopenshift:release-4.11from
openshift-cherrypick-robot:cherry-pick-3211-to-release-4.11

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Jul 4, 2022

This is an automated cherry-pick of #3211

/assign yuqi-zhang

@yuqi-zhang
daemon: initialize nodewriter before login monitor
5eb2154 
As part of openshift#3143
we re-ordered the clusterconnect operations. This meant that the login
monitor started before the nodewriter object was initialized, which
caused a race where the monitor could try to write the ssh accessed
annotation before the nodewriter was initialized, causing a panic.

This is good to get fixed, but also note that:
1. this is relatively rare since most users should not be ssh'ing
2. the general ssh accessed annotation is broken such that its not
   always applied, but we definitely should not panic here.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jul 4, 2022
Merged
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 4, 2022

@openshift-cherrypick-robot: Bugzilla bug 2099664 has been cloned as Bugzilla bug 2103749. Retitling PR to link against new bug.
/retitle [release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor

Details

In response to this:

[release-4.11] Bug 2099664: daemon: initialize nodewriter before login monitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot changed the title [release-4.11] Bug 2099664: daemon: initialize nodewriter before login monitor [release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor Jul 4, 2022
@openshift-ci openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 4, 2022

@openshift-cherrypick-robot: This pull request references Bugzilla bug 2103749, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.11.0) matches configured target release for branch (4.11.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 2099664 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 2099664 targets the "4.12.0" release, which is one of the valid target releases: 4.12.0
  • bug has dependents

Requesting review from QA contact:
/cc @rioliu-rh

Details

In response to this:

[release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yuqi-zhang
yuqi-zhang approved these changes Jul 4, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed
/lgtm

No risk, fixes race condition

@openshift-ci openshift-ci Bot added backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. lgtm Indicates that a PR is ready to be merged. labels Jul 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 4, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 4, 2022 •
edited
Loading

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-disruptive 5eb2154 link false /test e2e-aws-disruptive
ci/prow/e2e-vsphere-upgrade 5eb2154 link false /test e2e-vsphere-upgrade
ci/prow/e2e-aws-upgrade-single-node 5eb2154 link false /test e2e-aws-upgrade-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@rioliu-rh
Copy link
Copy Markdown

rioliu-rh commented Jul 5, 2022

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jul 5, 2022
@mrunalp mrunalp added the staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead). label Jul 5, 2022
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jul 5, 2022

/retest-required

Remaining retests: 2 against base HEAD 0f1ea77 and 8 for PR HEAD 5eb2154 in total

@openshift-ci openshift-ci Bot merged commit 3c97596 into openshift:release-4.11 Jul 6, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 6, 2022

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 2103749 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.11] Bug 2103749: daemon: initialize nodewriter before login monitor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@rioliu-rh rioliu-rh Awaiting requested review from rioliu-rh

@kikisdeliveryservice kikisdeliveryservice Awaiting requested review from kikisdeliveryservice

Assignees

@yuqi-zhang yuqi-zhang

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. staff-eng-approved Indicates a release branch PR has been approved by a staff engineer (formerly group/pillar lead).

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@openshift-cherrypick-robot @rioliu-rh @openshift-ci-robot @yuqi-zhang @mrunalp