Skip to content

OCPBUGS-11652: kubelet: add enableSystemLogQuery#3645

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:systemlogquery
May 8, 2023
Merged

OCPBUGS-11652: kubelet: add enableSystemLogQuery#3645
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:systemlogquery

Conversation

@aravindhp
Copy link
Copy Markdown
Contributor

@aravindhp aravindhp commented Mar 29, 2023

Now that the oc adm node-logs feature has been upstreamed, enable the kubelet config flag introduced in 1.27 to allow the feature to work downstream.

@aravindhp
kubelet: add enableSystemLogQuery
813ad2f 
Now that the "oc adm node-logs" feature has been upstreamed, enable the
kubelet config flag introduced in 1.27 to allow the feature to work
downstream.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 29, 2023
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 29, 2023 •
edited by openshift-ci Bot
Loading

@aravindhp: This pull request references WINC-1016 which is a valid jira issue.

Details

In response to this:

Now that the oc adm node-logs feature has been upstreamed, enable the kubelet config flag introduced in 1.27 to allow the feature to work downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 29, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Mar 29, 2023

/test ?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Mar 29, 2023

@aravindhp: The following commands are available to trigger required jobs:

  • /test 4.12-upgrade-from-stable-4.11-images
  • /test cluster-bootimages
  • /test e2e-aws-ovn
  • /test e2e-aws-ovn-upgrade
  • /test e2e-gcp-op
  • /test images
  • /test okd-scos-images
  • /test unit
  • /test verify

The following commands are available to trigger optional jobs:

  • /test 4.12-upgrade-from-stable-4.11-e2e-aws-ovn-upgrade
  • /test bootstrap-unit
  • /test e2e-alibabacloud-ovn
  • /test e2e-aws-disruptive
  • /test e2e-aws-ovn-fips
  • /test e2e-aws-ovn-fips-op
  • /test e2e-aws-ovn-workers-rhel8
  • /test e2e-aws-proxy
  • /test e2e-aws-serial
  • /test e2e-aws-single-node
  • /test e2e-aws-upgrade-single-node
  • /test e2e-aws-workers-rhel8
  • /test e2e-azure
  • /test e2e-azure-ovn-upgrade
  • /test e2e-azure-upgrade
  • /test e2e-gcp-op-single-node
  • /test e2e-gcp-ovn-rt-upgrade
  • /test e2e-gcp-rt
  • /test e2e-gcp-rt-op
  • /test e2e-gcp-single-node
  • /test e2e-gcp-upgrade
  • /test e2e-hypershift
  • /test e2e-metal-assisted
  • /test e2e-metal-ipi
  • /test e2e-metal-ipi-ovn-dualstack
  • /test e2e-metal-ipi-ovn-ipv6
  • /test e2e-openstack
  • /test e2e-openstack-externallb-techpreview
  • /test e2e-openstack-parallel
  • /test e2e-ovirt
  • /test e2e-ovirt-upgrade
  • /test e2e-ovn-step-registry
  • /test e2e-vsphere
  • /test e2e-vsphere-upgrade
  • /test e2e-vsphere-upi
  • /test e2e-vsphere-upi-zones
  • /test e2e-vsphere-zones
  • /test okd-e2e-aws
  • /test okd-e2e-gcp-op
  • /test okd-e2e-upgrade
  • /test okd-e2e-vsphere
  • /test okd-images
  • /test okd-scos-e2e-aws-ovn
  • /test okd-scos-e2e-gcp-op
  • /test okd-scos-e2e-gcp-ovn-upgrade
  • /test okd-scos-e2e-vsphere

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-machine-config-operator-master-e2e-alibabacloud-ovn
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn
  • pull-ci-openshift-machine-config-operator-master-e2e-aws-ovn-upgrade
  • pull-ci-openshift-machine-config-operator-master-e2e-gcp-op
  • pull-ci-openshift-machine-config-operator-master-e2e-hypershift
  • pull-ci-openshift-machine-config-operator-master-images
  • pull-ci-openshift-machine-config-operator-master-okd-images
  • pull-ci-openshift-machine-config-operator-master-okd-scos-e2e-aws-ovn
  • pull-ci-openshift-machine-config-operator-master-okd-scos-e2e-gcp-ovn-upgrade
  • pull-ci-openshift-machine-config-operator-master-okd-scos-images
  • pull-ci-openshift-machine-config-operator-master-unit
  • pull-ci-openshift-machine-config-operator-master-verify
Details

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Mar 29, 2023

/test e2e-vsphere

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Apr 3, 2023

/test unit

@rphillips
Copy link
Copy Markdown
Contributor

rphillips commented Apr 5, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, rphillips

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2023
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Apr 12, 2023

/retitle OCPBUGS-11652: kubelet: add enableSystemLogQuery

@openshift-ci openshift-ci Bot changed the title WINC-1016: kubelet: add enableSystemLogQuery OCPBUGS-11652: kubelet: add enableSystemLogQuery Apr 12, 2023
@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 12, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Apr 12, 2023

@aravindhp: This pull request references Jira Issue OCPBUGS-11652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Now that the oc adm node-logs feature has been upstreamed, enable the kubelet config flag introduced in 1.27 to allow the feature to work downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from zhouying7780 April 12, 2023 22:53
@aravindhp aravindhp marked this pull request as ready for review May 4, 2023 14:35
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@openshift-ci openshift-ci Bot requested review from cgwalters and jkyros May 4, 2023 14:35
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 4, 2023

/hold

until we payload with the 1.27 bump and an updated kubelet.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 4, 2023
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 5, 2023

/unhold

kube 1.27 bump has been picked up

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 5, 2023
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 5, 2023

/retest-required

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 5, 2023

/retest-required

e2e-gcp-op took too long to get a lease preventing the tests from completing due to the timeout.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 5, 2023

/retest-required

Remaining retests: 0 against base HEAD d74a28c and 2 for PR HEAD 813ad2f in total

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 6, 2023

/retest-required

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 6, 2023

/retest-required

e2e-gcp-op again hit the timeout

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented May 8, 2023

/retest-required

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 8, 2023 •
edited
Loading

@aravindhp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 813ad2f link false /test e2e-hypershift
ci/prow/okd-scos-e2e-aws-ovn 813ad2f link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 813ad2f link false /test okd-scos-e2e-gcp-ovn-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented May 8, 2023

/test e2e-gcp-op

@openshift-merge-robot openshift-merge-robot merged commit 5a8eddd into openshift:master May 8, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 8, 2023

@aravindhp: Jira Issue OCPBUGS-11652: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11652 has not been moved to the MODIFIED state.

Details

In response to this:

Now that the oc adm node-logs feature has been upstreamed, enable the kubelet config flag introduced in 1.27 to allow the feature to work downstream.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp deleted the systemlogquery branch May 9, 2023 02:03
@aravindhp aravindhp mentioned this pull request May 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@cgwalters cgwalters Awaiting requested review from cgwalters

@jkyros jkyros Awaiting requested review from jkyros

Assignees

@rphillips rphillips

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aravindhp @openshift-ci-robot @rphillips @sinnykumari @openshift-merge-robot