WIP: oc adm node-logs: Add compatibility with NodeLogQuery feature#1392
WIP: oc adm node-logs: Add compatibility with NodeLogQuery feature#1392ardaguclu wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ardaguclu The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/uncc @deads2k @mfojtik |
openshift-ci
Bot
requested review from
aravindhp and
soltysh
and removed request for
deads2k and
mfojtik
|
/test e2e-agnostic-ovn-cmd |
This PR aligns query parameters in oc adm node-log command with the new upstream feature NodeLogQuery. For a couple of oc versions, new and old APIs will both be supported by setting query parameters blindly to cover both versions.
ardaguclu
force-pushed
the
new-node-log-params
branch
from
321d893 to
3dfe80a
Compare
ardaguclu
changed the title
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
| } | ||
| } | ||
| if len(o.Grep) > 0 { | ||
| req.Param("pattern", o.Grep) |
There was a problem hiding this comment.
@aravindhp are pattern and grep interchangeable?.
|
|
||
| // TODO: deprecate this flag in 4.16 and use --pattern flag | ||
| req.Param("grep", o.Grep) | ||
| req.Param("case-sensitive", fmt.Sprintf("%t", o.GrepCaseSensitive)) |
There was a problem hiding this comment.
There is no corresponding flag of case-sensitive?
|
@ardaguclu: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
After discussions on Slack, it seems that this PR does not solve the problem we have. Therefore, I'm closing this one; /close |
|
@ardaguclu: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Replaced with #1403 |
2 participants
This PR aligns query parameters in oc adm node-log command with the new upstream feature NodeLogQuery. For a couple of oc versions, new and old APIs will both be supported by setting query parameters blindly to cover both versions.