Skip to content

OCPBUGS-11652: Enable oc adm node-logs#27992

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:OCPBUGS-11652
Jun 27, 2023
Merged

OCPBUGS-11652: Enable oc adm node-logs#27992
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
aravindhp:OCPBUGS-11652

Conversation

@aravindhp
Copy link
Copy Markdown
Contributor

@aravindhp aravindhp commented Jun 22, 2023 •
edited
Loading

Now that all the required PRs for the feature to work has merged, we can enable the test. Please the bug links for the list of PRs.

Manual revert of #27867

@aravindhp
Enable oc adm node-logs
9a162d5 
Now that all the required PRs for the feature to work has merged, we can
enable the test. Please the bug links for the list of PRs.
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 22, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 22, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 22, 2023

@aravindhp: This pull request references Jira Issue OCPBUGS-11652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Now that all the required PRs for the feature to work has merged, we can enable the test. Please the bug links for the list of PRs.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label Jun 22, 2023
@openshift-ci openshift-ci Bot requested a review from zhouying7780 June 22, 2023 18:59
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 22, 2023

/test lint verify unit e2e-gcp-ovn

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 22, 2023

@aravindhp: This pull request references Jira Issue OCPBUGS-11652, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

Now that all the required PRs for the feature to work has merged, we can enable the test. Please the bug links for the list of PRs.

Manual revert of #27867

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 22, 2023

/test e2e-gcp-ovn

cluster failed to come up on previous run

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 23, 2023

The test ran and passed:

passed: (23.7s) 2023-06-22T22:19:38 "[sig-cli] oc adm node-logs [Suite:openshift/conformance/parallel]"

@aravindhp aravindhp marked this pull request as ready for review June 23, 2023 00:00
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 23, 2023
@openshift-ci openshift-ci Bot requested review from orenc1 and soltysh June 23, 2023 00:01
@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 23, 2023

/assign @soltysh @ardaguclu

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 23, 2023

/unassign @soltysh @ardaguclu
/cc @ardaguclu

@openshift-ci openshift-ci Bot requested a review from ardaguclu June 23, 2023 16:19
@soltysh
Copy link
Copy Markdown
Contributor

soltysh commented Jun 23, 2023

/payload-job periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview
/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 23, 2023

@soltysh: trigger 2 job(s) for the /payload-(job|aggregate) command

  • periodic-ci-openshift-release-master-ci-4.14-e2e-aws-sdn-techpreview
  • periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9b3adb20-11e6-11ee-879e-5a82f7e3cf8d-0

@aravindhp
Copy link
Copy Markdown
Contributor Author

aravindhp commented Jun 23, 2023

I checked both periodics and I see : [sig-cli] oc adm node-logs [Suite:openshift/conformance/parallel] in the list of passing tests

@ardaguclu
Copy link
Copy Markdown
Member

ardaguclu commented Jun 26, 2023

Thanks @aravindhp
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 26, 2023
soltysh
soltysh approved these changes Jun 26, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aravindhp, ardaguclu, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 26, 2023

/retest-required

Remaining retests: 0 against base HEAD dd40ffb and 2 for PR HEAD 9a162d5 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 26, 2023 •
edited
Loading

@aravindhp: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-sdn 9a162d5 link false /test e2e-metal-ipi-sdn
ci/prow/e2e-aws-csi 9a162d5 link false /test e2e-aws-csi
ci/prow/e2e-openstack-ovn 9a162d5 link false /test e2e-openstack-ovn
ci/prow/e2e-aws-ovn-single-node-serial 9a162d5 link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-aws-ovn-single-node-upgrade 9a162d5 link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-agnostic-ovn-cmd 9a162d5 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 26, 2023

/retest-required

Remaining retests: 0 against base HEAD fb12a32 and 1 for PR HEAD 9a162d5 in total

@openshift-merge-robot openshift-merge-robot merged commit 0bca82e into openshift:master Jun 27, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 27, 2023

@aravindhp: Jira Issue OCPBUGS-11652: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-11652 has not been moved to the MODIFIED state.

Details

In response to this:

Now that all the required PRs for the feature to work has merged, we can enable the test. Please the bug links for the list of PRs.

Manual revert of #27867

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aravindhp aravindhp mentioned this pull request Jun 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhouying7780 zhouying7780 Awaiting requested review from zhouying7780

@orenc1 orenc1 Awaiting requested review from orenc1

@ardaguclu ardaguclu Awaiting requested review from ardaguclu

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ardaguclu ardaguclu

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aravindhp @openshift-ci-robot @soltysh @ardaguclu @openshift-merge-robot