OCPBUGS-18906: Remove dependency on k8s.io/kubernetes packages

[djoshy]

- What I did
Created internal objects since we were not using any functionality of the package anyway. We were just using it as a vehicle to marshal and unmarshal.

- How to verify it
Secrets merging should work as before.

- Description for the changelog
operator: removed k8s pkg dependancy

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-18906, which is invalid:

• expected the bug to target the "4.15.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

- What I did
Created internal objects since we were not using any functionality of the package anyway. We were just using it as a vehicle to marshal and unmarshal.

- How to verify it
Secrets merging should work as before.

- Description for the changelog
operator: removed k8s pkg dependancy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[djoshy]

/test unit
/test verify
/test e2e-gcp-op

[cgwalters]

Nice; I wonder if there's actually some public equivalent of this in the github.com/containers namespace? Using a search leads to the podman copy; another copy here looks like? https://github.com/containers/image/blob/255f36875ce5ca16bf941c18d4a2af2663daf952/pkg/docker/config/config.go#L26

May be worth trying to factor that out into a public type.

(But obviously, this is way better than vendoring kube, so please don't block on it, just a drive-by thought)

[djoshy]

/test e2e-gcp-op

/jira refresh

[openshift-ci-robot]

@djoshy: This pull request references Jira Issue OCPBUGS-18906, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.15.0) matches configured target version for branch (4.15.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @rioliu-rh

Details

In response to this:

/test e2e-gcp-op

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[djoshy]

/test all

[LorbusChris]

/test okd-scos-images

[sergiordlr]

Verified using IPI on GCP

All critical test cases passed

These test cases were executed and passed:

• "[sig-mco] MCO Layering Author:sregidor-ConnectedOnly-Longduration-NonPreRelease-Medium-54056-Update osImage using the internal registry to store the image [Disruptive] [Serial]"
• "[sig-mco] MCO Author:sregidor-NonPreRelease-Longduration-Medium-57595-Use empty pull-secret[Disruptive] [Serial]"
• "[sig-mco] MCO Author:mhanss-NonPreRelease-Longduration-High-42680-change pull secret in the openshift-config namespace [Serial]"

We can add the qe-approved label

/label qe-approved

[djoshy]

/retest-required

[openshift-ci]

@djoshy: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	f093628	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[sinnykumari]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [djoshy,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@djoshy: Jira Issue OCPBUGS-18906: All pull requests linked via external trackers have merged:

• openshift/machine-config-operator#3913

Jira Issue OCPBUGS-18906 has been moved to the MODIFIED state.

Details

In response to this:

- What I did
Created internal objects since we were not using any functionality of the package anyway. We were just using it as a vehicle to marshal and unmarshal.

- How to verify it
Secrets merging should work as before.

- Description for the changelog
operator: removed k8s pkg dependancy

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[djoshy]

/cherrypick release-4.14

[openshift-cherrypick-robot]

@djoshy: new pull request created: #3940

Details

In response to this:

/cherrypick release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.