Skip to content

mod: Update rpmostree-client-go#3916

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:update-rpmostree-client
Sep 20, 2023
Merged

mod: Update rpmostree-client-go#3916
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
cgwalters:update-rpmostree-client

Conversation

@cgwalters
Copy link
Copy Markdown
Member

No functional changes, but this clearly runs into the problem we're not regularly updating our dependencies...

Prep for #3857

Comment thread go.mod Outdated
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 13, 2023
@sinnykumari
Copy link
Copy Markdown
Contributor

sinnykumari commented Sep 19, 2023

#3913 merged, we hshould be good to update the PR with vendoring latest deps.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
@cgwalters cgwalters force-pushed the update-rpmostree-client branch from 513a3d7 to bd4d8f3 Compare September 19, 2023 20:21
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 19, 2023
No functional changes, but this *clearly* runs into the
problem we're not regularly updating our dependencies...
@cgwalters cgwalters force-pushed the update-rpmostree-client branch from bd4d8f3 to 5803955 Compare September 19, 2023 20:40
@sinnykumari
Copy link
Copy Markdown
Contributor

QE testing shouldn't be necessary since this is dep update.
/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [cgwalters,sinnykumari]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 26b12a4 and 2 for PR HEAD 5803955 in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Sep 20, 2023

@cgwalters: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 5803955 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit a9242bd into openshift:master Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants