bootstrap: Require images on command line

[cgwalters]

Since having a mismatch here will result in a broken cluster,
change things so that the command line arguments are required
and drop the docker.io image references. We never want
to pull those into a real cluster.

Ref: #367

[runcom]

/test unit

[runcom]

copy pasted /lgtm wrongly while reviewing other PRs lol but looks good

/lgtm cancel

[cgwalters]

And now if anyone wants to add a new MCO-managed image, they need to:

• Add a CLI option here with a default
• Change the installer to pass that arg with the image from the CVO
• Make the option required here

Or we change this bootstrap code to just parse the CVO payload directly which IMO would be saner, but this is the current status.

[jlebon]

And now if anyone wants to add a new MCO-managed image, they need to:

• Add a CLI option here with a default
• Change the installer to pass that arg with the image from the CVO
• Make the option required here

Can we write this down somewhere? Either as a comment in the code, or somewhere in HACKING.md or something.

[jlebon]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cgwalters, jlebon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cgwalters,jlebon]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[runcom]

/flake

/test e2e-aws

[runcom]

these are really aws running out of resources, let's hold retesting for a while

[ashcrow]

these are really aws running out of resources, let's hold retesting for a while

🤦‍♂️

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.