bootstrap: set --kube-ca default to empty

[mrogers950]

This PR is a follow-up regarding #420 (comment)
The installer now uses the flag with openshift/installer#1266.
/cc @cgwalters

[ashcrow]

Change looks fine, but why default to empty rather than a default? As an example, the next line has a default in /assets/ as well.

[mrogers950]

Change looks fine, but why default to empty rather than a default? As an example, the next line has a default in /assets/ as well.

The code makes including the kube-ca optional if it's empty, so I was keeping it in line with that. I was not sure if this command ran under any other context than the installer in order to have a given default be useful.

[mrogers950]

/retest

[ashcrow]

The code makes including the kube-ca optional if it's empty, so I was keeping it in line with that. I was not sure if this command ran under any other context than the installer in order to have a given default be useful.

That's fair. 👍

[kikisdeliveryservice]

LGTM but will defer to @cgwalters to approve

/assign @cgwalters

[kikisdeliveryservice]

400 response & HAProxy flakes:

/test e2e-aws

[cgwalters]

/lgtm

But FWIW in #403 we changed things to error out if the option isn't provided. There aren't any use cases for this CLI other than the installer.

But eh, not worth respinning now.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ashcrow, cgwalters, mrogers950

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [ashcrow,cgwalters]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[ashcrow]

Flake

    --- FAIL: TestContainerRuntimeConfigCreate/unrecognized (0.00s)

/retest