MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API#4962
Merged
openshift-merge-bot[bot] merged 3 commits intoopenshift:mainfrom Apr 10, 2025
Merged
Conversation
openshift-ci-robot
added
the
jira/valid-reference
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
approved
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
force-pushed
the
mco-1544-apiBump
branch
from
a54bf84 to
3353da9
Compare
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
force-pushed
the
mco-1544-apiBump
branch
3 times, most recently
from
132646e to
cdae5f0
Compare
Contributor
|
@isabella-janssen you would need to remove this as well since the MCN.Spec.PIS does not exist anymore:
|
openshift-merge-robot
added
the
needs-rebase
isabella-janssen
force-pushed
the
mco-1544-apiBump
branch
from
423bdef to
6641e3a
Compare
openshift-merge-robot
removed
the
needs-rebase
isabella-janssen
force-pushed
the
mco-1544-apiBump
branch
from
6bc1c1f to
0fcfc07
Compare
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
isabella-janssen
force-pushed
the
mco-1544-apiBump
branch
from
722b214 to
e275bbe
Compare
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
djoshy
approved these changes
Apr 4, 2025
Contributor
djoshy
left a comment
djoshy
left a comment
There was a problem hiding this comment.
Overall looks good to me, thanks for the fixups!
Will do final lgtm tag after pre merge QE testing
/hold
openshift-ci
Bot
added
the
do-not-merge/hold
Member
Author
|
/retest-required |
2 similar comments
Member
Author
|
/retest-required |
Member
Author
|
/retest-required |
Contributor
|
Pre-merge verification steps:
Custom MCP template$oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfigPool
metadata:
name: infra
spec:
machineConfigSelector:
matchExpressions:
- {key: machineconfiguration.openshift.io/role, operator: In, values: [worker,infra]}
nodeSelector:
matchLabels:
node-role.kubernetes.io/infra: ""
EOF
machineconfigpool.machineconfiguration.openshift.io/infra created
$ oc get machineconfignode -o wide NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED UPDATEPREPARED UPDATEEXECUTED UPDATEPOSTACTIONCOMPLETE UPDATECOMPLETE RESUMED UPDATEDFILESANDOS CORDONEDNODE DRAINEDNODE REBOOTEDNODE UNCORDONEDNODE ip-10-0-118-194.us-east-2.compute.internal infra rendered-infra-da792628ef260f08e7cd8e3c007f3676 rendered-infra-da792628ef260f08e7cd8e3c007f3676 True False False False False False False False False False False ip-10-0-119-206.us-east-2.compute.internal master rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e True False False False False False False False False False False ip-10-0-120-15.us-east-2.compute.internal worker rendered-worker-da792628ef260f08e7cd8e3c007f3676 rendered-worker-da792628ef260f08e7cd8e3c007f3676 True False False False False False False False False False False ip-10-0-122-238.us-east-2.compute.internal master rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e True False False False False False False False False False False ip-10-0-35-23.us-east-2.compute.internal worker rendered-worker-da792628ef260f08e7cd8e3c007f3676 rendered-worker-da792628ef260f08e7cd8e3c007f3676 True False False False False False False False False False False ip-10-0-55-132.us-east-2.compute.internal master rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e True False False False False False False False False False False
$ for node in $(oc get nodes -l node-role.kubernetes.io/worker -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="UpdateCompatible")]}' | jq;
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="ReloadedCRIO")]}' | jq;
done
ip-10-0-22-61.us-west-2.compute.internal
ip-10-0-76-141.us-west-2.compute.internal
ip-10-0-80-224.us-west-2.compute.internal
$ for node in $(oc get nodes -l node-role.kubernetes.io/master -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="UpdateCompatible")]}' | jq;
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="ReloadedCRIO")]}' | jq;
done
ip-10-0-16-88.us-west-2.compute.internal
ip-10-0-67-129.us-west-2.compute.internal
ip-10-0-82-37.us-west-2.compute.internal
MC template oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
labels:
machineconfiguration.openshift.io/role: worker
name: test-file
spec:
config:
ignition:
version: 3.4.0
storage:
files:
- contents:
source: data:text/plain;charset=utf-8;base64,dGVzdA==
filesystem: root
mode: 420
path: /etc/test-file.test
EOF
machineconfig.machineconfiguration.openshift.io/test-file created
LogsBefore$ for node in $(oc get nodes -l node-role.kubernetes.io/worker -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="RebootedNode")]}' | jq
done
ip-10-0-118-194.us-east-2.compute.internal
NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED
ip-10-0-118-194.us-east-2.compute.internal infra rendered-infra-bdb870f430ab906759dac44c2dd69453 rendered-infra-da792628ef260f08e7cd8e3c007f3676 False
{
"lastTransitionTime": "2025-04-08T14:28:30Z",
"message": "This node has not yet entered the RebootedNode phase",
"reason": "NotYetOccurred",
"status": "False",
"type": "RebootedNode"
}
…..
During
$ for node in $(oc get nodes -l node-role.kubernetes.io/worker -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -o wide
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="RebootedNode")]}' | jq
done
ip-10-0-118-194.us-east-2.compute.internal
NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED UPDATEPREPARED UPDATEEXECUTED UPDATEPOSTACTIONCOMPLETE UPDATECOMPLETE RESUMED UPDATEDFILESANDOS CORDONEDNODE DRAINEDNODE REBOOTEDNODE UNCORDONEDNODE
ip-10-0-118-194.us-east-2.compute.internal infra rendered-infra-bdb870f430ab906759dac44c2dd69453 rendered-infra-da792628ef260f08e7cd8e3c007f3676 False True True False False False True True True Unknown False
{
"lastTransitionTime": "2025-04-08T16:50:17Z",
"message": "Upgrade requires a reboot.",
"reason": "RebootedNode",
"status": "Unknown",
"type": "RebootedNode"
}
……
After
$ for node in $(oc get nodes -l node-role.kubernetes.io/worker -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -o wide
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="RebootedNode")]}' | jq
done
ip-10-0-118-194.us-east-2.compute.internal
NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED UPDATEPREPARED UPDATEEXECUTED UPDATEPOSTACTIONCOMPLETE UPDATECOMPLETE RESUMED UPDATEDFILESANDOS CORDONEDNODE DRAINEDNODE REBOOTEDNODE UNCORDONEDNODE
ip-10-0-118-194.us-east-2.compute.internal infra rendered-infra-bdb870f430ab906759dac44c2dd69453 rendered-infra-bdb870f430ab906759dac44c2dd69453 True False False False False False False False False False False
{
"lastTransitionTime": "2025-04-08T16:51:36Z",
"message": "Action during update to rendered-infra-bdb870f430ab906759dac44c2dd69453: Node has rebooted",
"reason": "RebootedNode",
"status": "False",
"type": "RebootedNode"
}
….
Wrong MC template oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: MachineConfig
metadata:
labels:
machineconfiguration.openshift.io/role: infra
name: test-file-infra
spec:
config:
ignition:
version: 3.4.0
storage:
files:
- contents:
source: data:text/plain;charset=utf-8;base64,dGVzdA==
filesystem: root
mode: 420
path: /etc2/test-file.test
EOF
machineconfig.machineconfiguration.openshift.io/test-file-infra created
$ oc get mcp NAME CONFIG UPDATED UPDATING DEGRADED MACHINECOUNT READYMACHINECOUNT UPDATEDMACHINECOUNT DEGRADEDMACHINECOUNT AGE infra rendered-infra-bdb870f430ab906759dac44c2dd69453 False True True 1 0 0 1 102m master rendered-master-c21ec021d9c9a6c7429aa1f2c5b5041e True False False 3 3 3 0 159m worker rendered-worker-bdb870f430ab906759dac44c2dd69453 True False False 2 2 2 0 159m
oc describe machineconfignode ip-10-0-31-154.us-west-2.compute.internal
Name: ip-10-0-31-154.us-west-2.compute.internal
Namespace:
Labels:
Annotations:
API Version: machineconfiguration.openshift.io/v1alpha1
Kind: MachineConfigNode
Metadata:
Creation Timestamp: 2025-04-09T03:55:38Z
Generation: 6
Owner References:
API Version: v1
Kind: Node
Name: ip-10-0-31-154.us-west-2.compute.internal
UID: dde5edc3-565b-4e43-9427-403cc315c46e
Resource Version: 79694
UID: 277b2f1b-2c40-4f6e-8d12-30cb8aaaca9f
Spec:
Config Version:
Desired: rendered-infra-d58c96878f0bde7ff712d0e5767fdf9b
Node:
Name: ip-10-0-31-154.us-west-2.compute.internal
Pool:
Name: infra
Status:
Conditions:
Last Transition Time: 2025-04-09T06:01:53Z
Message: All pinned image sets complete
Reason: AsExpected
Status: False
Type: PinnedImageSetsProgressing
Last Transition Time: 2025-04-09T06:13:41Z
Message: Update Compatible. Post Cfg Actions: [] Drain Required: true
Reason: UpdatePrepared
Status: True
Type: UpdatePrepared
Last Transition Time: 2025-04-09T06:16:21Z
Message: Updating the Files and OS on disk as a part of the in progress phase
Reason: AppliedFilesAndOS
Status: Unknown
Type: UpdateExecuted
Last Transition Time: 2025-04-09T04:48:47Z
Message: Action during update to rendered-infra-77d571521c92751cb13c2ded5ca69f5a: Changes do not require a reboot
Reason: None
Status: False
Type: UpdatePostActionComplete
Last Transition Time: 2025-04-09T06:02:05Z
Message: Action during update to rendered-infra-2ffa42a87126fb01994b1241825df993: Uncordoned Node as part of completing upgrade phase
Reason: Uncordoned
Status: False
Type: UpdateComplete
Last Transition Time: 2025-04-09T06:02:05Z
Message: Action during update to rendered-infra-2ffa42a87126fb01994b1241825df993: In desired config rendered-infra-77d571521c92751cb13c2ded5ca69f5a. Resumed normal operations.
Reason: Resumed
Status: False
Type: Resumed
Last Transition Time: 2025-04-09T06:16:19Z
Message: Drained node. The drain is complete as the desired drainer matches current drainer: drain-rendered-infra-d58c96878f0bde7ff712d0e5767fdf9b
Reason: UpdateExecutedDrained
Status: True
Type: Drained
Last Transition Time: 2025-04-09T06:16:21Z
Message: Applying files and new OS config to node. OS will not need an update. SSH Keys will not need an update
Reason: UpdateExecutedAppliedFilesAndOS
Status: Unknown
Type: AppliedFilesAndOS
Last Transition Time: 2025-04-09T06:13:46Z
Message: Cordoned node. The node is reporting Unschedulable = true
Reason: UpdateExecutedCordoned
Status: True
Type: Cordoned
Last Transition Time: 2025-04-09T06:02:05Z
Message: Action during update to rendered-infra-2ffa42a87126fb01994b1241825df993: Node has rebooted
Reason: RebootedNode
Status: False
Type: RebootedNode
Last Transition Time: 2025-04-09T06:13:39Z
Message: Node ip-10-0-31-154.us-west-2.compute.internal needs an update
Reason: Updated
Status: False
Type: Updated
Last Transition Time: 2025-04-09T06:02:05Z
Message: Action during update to rendered-infra-2ffa42a87126fb01994b1241825df993: UnCordoned node. The node is reporting Unschedulable = false
Reason: UpdateCompleteUncordoned
Status: False
Type: Uncordoned
Last Transition Time: 2025-04-09T06:01:53Z
Message: All is good
Reason: AsExpected
Status: False
Type: PinnedImageSetsDegraded
Config Version:
Current: rendered-infra-2ffa42a87126fb01994b1241825df993
Desired: rendered-infra-d58c96878f0bde7ff712d0e5767fdf9b
Observed Generation: 7
Events:
PIS template for infra pool$ oc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: infra
name: tc-80334-infrar-pinned-images
spec:
pinnedImages:
- name: "quay.io/openshifttest/busybox@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
- name: quay.io/openshifttest/alpine@sha256:be92b18a369e989a6e86ac840b7f23ce0052467de551b064796d67280dfa06d5
EOF
pinnedimageset.machineconfiguration.openshift.io/tc-80334-infrar-pinned-images created
$ for node in $(oc get nodes -l node-role.kubernetes.io/infra -o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -o wide
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="PinnedImageSetsProgressing")]}' | jq
done
ip-10-0-118-194.us-east-2.compute.internal
NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED UPDATEPREPARED UPDATEEXECUTED UPDATEPOSTACTIONCOMPLETE UPDATECOMPLETE RESUMED UPDATEDFILESANDOS CORDONEDNODE DRAINEDNODE REBOOTEDNODE UNCORDONEDNODE
ip-10-0-118-194.us-east-2.compute.internal infra rendered-infra-da792628ef260f08e7cd8e3c007f3676 rendered-infra-da792628ef260f08e7cd8e3c007f3676 True False False False False False False False False False False
{
"lastTransitionTime": "2025-04-08T15:22:00Z",
"message": "All pinned image sets complete",
"reason": "AsExpected",
"status": "False",
"type": "PinnedImageSetsProgressing"
}
$ oc debug node/ip-10-0-118-194.us-east-2.compute.internal -- chroot /host crictl images --pinned
Starting pod/ip-10-0-118-194us-east-2computeinternal-debug-4c45w ...
To use host binaries, run `chroot /host`
IMAGE TAG IMAGE ID SIZE PINNED
….
quay.io/openshifttest/alpine 45683da4f97c2 5.87MB true
quay.io/openshifttest/busybox b97242f89c8a2 1.45MB true
Wrong PIS templateoc create -f - << EOF
apiVersion: machineconfiguration.openshift.io/v1
kind: PinnedImageSet
metadata:
labels:
machineconfiguration.openshift.io/role: infra
name: tc-80334-infrar-pinned-images-wrong
spec:
pinnedImages:
- name: "quay.io/openshifttest/fake@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019"
EOF
pinnedimageset.machineconfiguration.openshift.io/tc-80334-infrar-pinned-images-wrong created
$ for node in $(oc get nodes -l node-role.kubernetes.io/infra-o name)
do
n=${node/node\//}
echo $n
oc get machineconfignode $n -o wide
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="PinnedImageSetsProgressing")]}' | jq;
oc get machineconfignode $n -ojsonpath='{.status.conditions[?(@.type=="PinnedImageSetsDegraded")]}' | jq
done
ip-10-0-22-61.us-west-2.compute.internal
NAME POOLNAME DESIREDCONFIG CURRENTCONFIG UPDATED UPDATEPREPARED UPDATEEXECUTED UPDATEPOSTACTIONCOMPLETE UPDATECOMPLETE RESUMED UPDATEDFILESANDOS CORDONEDNODE DRAINEDNODE REBOOTEDNODE UNCORDONEDNODE
ip-10-0-22-61.us-west-2.compute.internal infra rendered-infra-4dbfd2b60e0d199db92d1d1e04067a6b rendered-infra-4dbfd2b60e0d199db92d1d1e04067a6b True False False False False False False False False False False
{
"lastTransitionTime": "2025-04-09T08:51:10Z",
"message": "node is prefetching images: ip-10-0-22-61.us-west-2.compute.internal",
"reason": "ImagePrefetch",
"status": "True",
"type": "PinnedImageSetsProgressing"
}
{
"lastTransitionTime": "2025-04-09T08:51:12Z",
"message": "One or more PinnedImageSet is experiencing an error. See PinnedImageSet list for more details",
"reason": "PrefetchFailed",
"status": "True",
"type": "PinnedImageSetsDegraded"
}
$ oc describe machineconfignode ip-10-0-118-194.us-east-2.compute.internal
…….
Pinned Image Sets:
Desired Generation: 1
Last Failed Generation: 1
Last Failed Generation Error: failed to execute podman manifest inspect for "quay.io/openshifttest/fake@sha256:0415f56ccc05526f2af5a7ae8654baec97d4a614f24736e8eef41a4591f08019": exit status 125
Name: tc-80334-infrar-pinned-images-wrong
Events:
|
Contributor
|
/lgtm feel free to unhold after QE tag has been applied |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djoshy, isabella-janssen The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
|
Working on TC fix to adapt as per the changes once PR is merged will create the PR helping to run successful CI job. /label qe-approved |
openshift-ci
Bot
added
the
qe-approved
Contributor
|
@isabella-janssen: This pull request references MCO-1544 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Contributor
|
/unhold /retest-required |
openshift-ci
Bot
removed
the
do-not-merge/hold
Contributor
|
@isabella-janssen: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Member
Author
|
/retest-required |
openshift-merge-bot
Bot
merged commit 88b9bb6
into
openshift:main
15 of 17 checks passed
Contributor
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Spec.PinnedImageSetsin MCN v1alpha1 API api#2256MachineConfigNodeUpdateCompatibleandMachineConfigNodeUpdateReloaded.LastFailedGenerationErrorsfield. Add newLastFailedGenerationErrorfield.MachineConfigNodePinnedImageSetsDegradedcondition isTrue.getPinnedImageSetSpecForPoolsfunction to cleanup remainingMachineConfigNodeSpecPinnedImageSetreferences.- How to verify it
UPDATECOMPATIBLEandRELOADEDCRIOshould not be in the output ofoc get machineconfignode -o wide.The conditions list of a MachineConfigNode should not include items with type
UpdateCompatibleorReloadedCRIO.MachineConfigNodeUpdateRebootedas a parent phase.Before the update
During the reboot
After successful reboot
The error message in the
PinnedImageSetsDegradedMCN conditions and PIS status reference should now be a generalized message and theLastFailedGenerationErrorsfield should now be a string type field calledLastFailedGenerationError.The MCN conditions and PIS status reference should report as before.
Note that the new MCN API validation requires that
LastFailedGenerationErroris populated when aLastFailedGenerationvalue is reported. Since the defaultLastFailedGenerationof 0 always showed on a successful PIS application (as tested in cluster version4.19.0-0.nightly-arm64-2025-03-21-080021), an empty string forLastFailedGenerationErroris now also being reported. This will not be fixed in this PR as it is a result of an existing bug (see OCPBUG-54592).- Description for the changelog
MCO-1544: Update MCO code to use MCN’s updated v1alpha1 API