[release-4.19] OCPBUGS-43435: After OCL is enabled few phases in MCN are not updating as expected by dkhater-redhat · Pull Request #5606 · openshift/machine-config-operator

dkhater-redhat · 2026-01-28T21:56:05Z

What I did

Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.

How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

Description for the changelog

openshift-ci-robot · 2026-01-28T21:56:11Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43435, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-43435 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

What I did

Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.

How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dkhater-redhat · 2026-01-28T22:04:24Z

/jira refresh

openshift-ci-robot · 2026-01-28T22:04:29Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43435, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-43435 to depend on a bug targeting a version in 4.20.0, 4.20.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen

/lgtm

openshift-ci · 2026-01-28T22:15:53Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, isabella-janssen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dkhater-redhat,isabella-janssen]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

isabella-janssen · 2026-01-29T14:25:45Z

/jira refresh

openshift-ci-robot · 2026-01-29T14:25:54Z

@isabella-janssen: This pull request references Jira Issue OCPBUGS-43435, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74646 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74646 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

umohnani8 · 2026-02-02T18:25:26Z

LGTM
/label backport-risk-assessed

@dkhater-redhat does QE need to verify or we can bypass?

ptalgulk01 · 2026-02-04T07:03:13Z

Pre-merge verified:

Environment Setup:
OCP Version: 4.19.0-0-2026-02-03-100850-test-ci-ln-108ryr2-latest
Platform: AWS

Verification Steps:

Applied MC to check the MCN status:

$  oc get machineconfignode -o wide -w
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   True      16h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     Unknown             True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            True      True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   True      16h   False            False            False                      False            False     False               False          False         False          False

Applied MOSC to check the MCN status update

ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     Unknown             True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            True      True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   True      17h   False            False            False                      False            False     False               False          False         False          False

Able to see the status of UPDATEPREPARED and UPDATEDFILESANDOS transition from False to True/Unknown as expected. For UPDATECOMPATIBLE is no longer present. #4962

/label qe-approved
/verified by @ptalgulk01

openshift-ci-robot · 2026-02-04T07:03:20Z

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-43435, which is valid.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.19.z) matches configured target version for branch (4.19.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
release note type set to "Release Note Not Required"
dependent bug Jira Issue OCPBUGS-74646 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-74646 targets the "4.20.z" version, which is one of the valid target versions: 4.20.0, 4.20.z
bug has dependents

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

What I did

Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.

How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-04T07:03:26Z

@ptalgulk01: This PR has been marked as verified by @ptalgulk01.

Details

In response to this:

Pre-merge verified:

Environment Setup:
OCP Version: 4.19.0-0-2026-02-03-100850-test-ci-ln-108ryr2-latest
Platform: AWS

Verification Steps:

Applied MC to check the MCN status:

$  oc get machineconfignode -o wide -w
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   True      16h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     False               True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             Unknown          False                      False            False     Unknown             True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          Unknown        False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      False            True      True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-cd0f457b9dd05edeff20e65c84844e5e   False     16h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   True      16h   False            False            False                      False            False     False               False          False         False          False

Applied MOSC to check the MCN status update

ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   False            False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             False            False                      False            False     False               False          False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           False         False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           Unknown       False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     False               True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             Unknown          False                      False            False     Unknown             True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          False          False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            False     True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      False            True      True                True           True          True           False
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   False     17h   True             True             False                      True             True      True                True           True          True           True
ip-10-0-80-148.us-east-2.compute.internal   worker     rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   rendered-worker-6d1193681e8b9aa8e1b9fab18b92fec2   True      17h   False            False            False                      False            False     False               False          False         False          False

Able to see the status of UPDATEPREPARED and UPDATEDFILESANDOS transition from False to True/Unknown as expected. For UPDATECOMPATIBLE is no longer present. #4962

/label qe-approved
/verified by @ptalgulk01

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-02-04T07:50:37Z

/retest-required

Remaining retests: 0 against base HEAD b405535 and 2 for PR HEAD 1b30b59 in total

isabella-janssen · 2026-02-04T13:48:07Z

/retest-required

dkhater-redhat · 2026-02-05T17:11:37Z

/test e2e-gcp-op

openshift-ci · 2026-02-05T21:29:13Z

@dkhater-redhat: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot · 2026-02-05T21:31:11Z

@dkhater-redhat: Jira Issue Verification Checks: Jira Issue OCPBUGS-43435
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-43435 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

What I did

Added missing MachineConfigNode condition updates to updateOnClusterBuild() for UpdatePrepared, UpdateCompatible, and UpdateFilesAndOS. These conditions were only being set in the regular update() path, causing them to remain False when OCL is enabled.

How to verify it

Enable OCL on a cluster
Apply a MachineConfig change
Watch oc get machineconfignode -w -o wide
Verify the UPDATEPREPARED, UPDATECOMPATIBLE, and UPDATEDFILESANDOS columns transition from False to True/Unknown as expected, matching the behavior without OCL

Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-merge-robot · 2026-02-08T01:15:50Z

Fix included in accepted release 4.19.0-0.nightly-2026-02-07-200417

openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 28, 2026

openshift-ci Bot requested review from djoshy and yuqi-zhang January 28, 2026 21:58

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2026

Fix MCN conditions not updating during OCL sync

1b30b59

dkhater-redhat force-pushed the fix-mcn-conditions-ocl-4.19 branch from c675728 to 1b30b59 Compare January 28, 2026 22:02

isabella-janssen reviewed Jan 28, 2026

View reviewed changes

openshift-ci Bot assigned isabella-janssen Jan 28, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2026

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jan 29, 2026

openshift-ci Bot requested a review from sergiordlr January 29, 2026 14:25

openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Feb 2, 2026

openshift-ci Bot assigned anuragthehatter, imatza-rh, lyman9966, mhanss, ptalgulk01, rbbratta, rioliu-rh, sergiordlr and zhaozhanqi Feb 2, 2026

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Feb 4, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 4, 2026

openshift-merge-bot Bot merged commit 25321ab into openshift:release-4.19 Feb 5, 2026
14 checks passed

Conversation

dkhater-redhat commented Jan 28, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026

Uh oh!

dkhater-redhat commented Jan 28, 2026

Uh oh!

openshift-ci-robot commented Jan 28, 2026

Uh oh!

isabella-janssen left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jan 28, 2026

Uh oh!

isabella-janssen commented Jan 29, 2026

Uh oh!

openshift-ci-robot commented Jan 29, 2026

Uh oh!

umohnani8 commented Feb 2, 2026

Uh oh!

ptalgulk01 commented Feb 4, 2026

Uh oh!

openshift-ci-robot commented Feb 4, 2026

Uh oh!

openshift-ci-robot commented Feb 4, 2026

Uh oh!

openshift-ci-robot commented Feb 4, 2026

Uh oh!

isabella-janssen commented Feb 4, 2026

Uh oh!

dkhater-redhat commented Feb 5, 2026

Uh oh!

openshift-ci Bot commented Feb 5, 2026

Uh oh!

Uh oh!

openshift-ci-robot commented Feb 5, 2026

Uh oh!

openshift-merge-robot commented Feb 8, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants